summaryrefslogtreecommitdiff
path: root/source4/dsdb
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2007-02-11 17:51:38 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 14:44:59 -0500
commit9bdb49455aa6ad38f71375f602e691d2b7765d04 (patch)
tree95e80e32a2298ede35ce68e4f96a237b5338f247 /source4/dsdb
parente38fad186f3dd0977f8601b3adf57a3008bfb9b9 (diff)
downloadsamba-9bdb49455aa6ad38f71375f602e691d2b7765d04.tar.gz
samba-9bdb49455aa6ad38f71375f602e691d2b7765d04.tar.bz2
samba-9bdb49455aa6ad38f71375f602e691d2b7765d04.zip
r21282: we only need one for loop...
metze (This used to be commit 181b3a031f9683ea5e9aa2c96f121639561c6830)
Diffstat (limited to 'source4/dsdb')
-rw-r--r--source4/dsdb/repl/replicated_objects.c12
1 files changed, 5 insertions, 7 deletions
diff --git a/source4/dsdb/repl/replicated_objects.c b/source4/dsdb/repl/replicated_objects.c
index 9f6ce4c519..08a349d1c3 100644
--- a/source4/dsdb/repl/replicated_objects.c
+++ b/source4/dsdb/repl/replicated_objects.c
@@ -88,13 +88,6 @@ static WERROR dsdb_convert_object(struct ldb_context *ldb,
msg->num_elements);
W_ERROR_HAVE_NO_MEMORY(msg->elements);
- for (i=0; i < msg->num_elements; i++) {
- status = dsdb_attribute_drsuapi_to_ldb(schema,
- &in->object.attribute_ctr.attributes[i],
- msg->elements, &msg->elements[i]);
- W_ERROR_NOT_OK_RETURN(status);
- }
-
md = talloc(mem_ctx, struct replPropertyMetaDataBlob);
W_ERROR_HAVE_NO_MEMORY(md);
@@ -111,10 +104,15 @@ static WERROR dsdb_convert_object(struct ldb_context *ldb,
struct drsuapi_DsReplicaAttribute *a;
struct drsuapi_DsReplicaMetaData *d;
struct replPropertyMetaData1 *m;
+ struct ldb_message_element *e;
a = &in->object.attribute_ctr.attributes[i];
d = &in->meta_data_ctr->meta_data[i];
m = &md->ctr.ctr1.array[i];
+ e = &msg->elements[i];
+
+ status = dsdb_attribute_drsuapi_to_ldb(schema, a, msg->elements, e);
+ W_ERROR_NOT_OK_RETURN(status);
m->attid = a->attid;
m->version = d->version;