diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2008-10-27 13:32:23 +1100 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2008-11-04 16:06:56 +1100 |
| commit | 9381a78c391bcccd5eddc159a5d3a3e12d19fde3 (patch) | |
| tree | 81d9b89532c4e6019e3417b864f68b127fbb71ac /source4/lib/ldb/common/ldb_ldif.c | |
| parent | adf016e11946a354a140b1c0ed7789160e3af2aa (diff) | |
| download | samba-9381a78c391bcccd5eddc159a5d3a3e12d19fde3.tar.gz samba-9381a78c391bcccd5eddc159a5d3a3e12d19fde3.tar.bz2 samba-9381a78c391bcccd5eddc159a5d3a3e12d19fde3.zip | |
Use ldb_dn_from_ldb_val to avoid possible over-run of the value.
The ldb_val is length-limited, and while normally NULL terminated,
this avoids the chance that this particular value might not be, as
well as avoiding a cast.
Andrew Bartlett
Diffstat (limited to 'source4/lib/ldb/common/ldb_ldif.c')
| -rw-r--r-- | source4/lib/ldb/common/ldb_ldif.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/lib/ldb/common/ldb_ldif.c b/source4/lib/ldb/common/ldb_ldif.c index fb93e17c6c..538ff8feaa 100644 --- a/source4/lib/ldb/common/ldb_ldif.c +++ b/source4/lib/ldb/common/ldb_ldif.c @@ -562,11 +562,11 @@ struct ldb_ldif *ldb_ldif_read(struct ldb_context *ldb, goto failed; } - msg->dn = ldb_dn_new(msg, ldb, (char *)value.data); + msg->dn = ldb_dn_from_ldb_val(msg, ldb, &value); if ( ! ldb_dn_validate(msg->dn)) { ldb_debug(ldb, LDB_DEBUG_ERROR, "Error: Unable to parse dn '%s'\n", - value.data); + (char *)value.data); goto failed; } |