summaryrefslogtreecommitdiff
path: root/source4/lib/ldb/common
diff options
context:
space:
mode:
authorMatthias Dieter Wallnöfer <mdw@samba.org>2011-04-07 10:11:46 +0200
committerMatthias Dieter Wallnöfer <mdw@samba.org>2011-04-07 15:53:20 +0200
commitdf9d46a353da15f68d299498f36ab0474c8e1e5a (patch)
tree8dd3ce6f8634c01f7b348e6018081c0219ca3c26 /source4/lib/ldb/common
parentddb41f2af48caa856ce45338cffaadaa9226c76c (diff)
downloadsamba-df9d46a353da15f68d299498f36ab0474c8e1e5a.tar.gz
samba-df9d46a353da15f68d299498f36ab0474c8e1e5a.tar.bz2
samba-df9d46a353da15f68d299498f36ab0474c8e1e5a.zip
ldb:ldb_msg_check_sanity - clean it up from unneeded stuff
Diffstat (limited to 'source4/lib/ldb/common')
-rw-r--r--source4/lib/ldb/common/ldb_msg.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/source4/lib/ldb/common/ldb_msg.c b/source4/lib/ldb/common/ldb_msg.c
index d1c77f89bc..8060476d7d 100644
--- a/source4/lib/ldb/common/ldb_msg.c
+++ b/source4/lib/ldb/common/ldb_msg.c
@@ -772,7 +772,6 @@ int ldb_msg_sanity_check(struct ldb_context *ldb,
/* basic check on DN */
if (msg->dn == NULL) {
- /* TODO: return also an error string */
ldb_set_errstring(ldb, "ldb message lacks a DN!");
return LDB_ERR_INVALID_DN_SYNTAX;
}
@@ -781,13 +780,10 @@ int ldb_msg_sanity_check(struct ldb_context *ldb,
for (i = 0; i < msg->num_elements; i++) {
for (j = 0; j < msg->elements[i].num_values; j++) {
if (msg->elements[i].values[j].length == 0) {
- TALLOC_CTX *mem_ctx = talloc_new(ldb);
/* an attribute cannot be empty */
- /* TODO: return also an error string */
ldb_asprintf_errstring(ldb, "Element %s has empty attribute in ldb message (%s)!",
msg->elements[i].name,
ldb_dn_get_linearized(msg->dn));
- talloc_free(mem_ctx);
return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
}
}