r3304: changed the API to lib/socket/ a little.

The main change is to make socket_recv() take a pre-allocated buffer,
rather than allocating one itself. This allows non-blocking users of
this API to avoid a memcpy(). As a result our messaging code is now
about 10% faster, and the ncacn_ip_tcp and ncalrpc code is also
faster.

The second change was to remove the unused mem_ctx argument from
socket_send(). Having it there implied that memory could be allocated,
which meant the caller had to worry about freeing that memory (if for
example it is sending in a tight loop using the same memory
context). Removing that unused argument keeps life simpler for users.
(This used to be commit a16e4756cd68ca8aab4ffc59d4d9db0b6e44dbd1)

1 files changed, 4 insertions, 4 deletions

diff --git a/source4/lib/socket/socket.h b/source4/lib/socket/socket.h
index a089a1b78a..6562bb376b 100644
--- a/source4/lib/socket/socket.h
+++ b/source4/lib/socket/socket.h
@@ -46,10 +46,10 @@ struct socket_ops {
 				struct socket_context **new_sock, uint32_t flags);
 
 	/* general ops */
-	NTSTATUS (*recv)(struct socket_context *sock, TALLOC_CTX *mem_ctx, 
-				DATA_BLOB *blob, size_t wantlen, uint32_t flags);
-	NTSTATUS (*send)(struct socket_context *sock, TALLOC_CTX *mem_ctx,
-				const DATA_BLOB *blob, size_t *sendlen, uint32_t flags);
+	NTSTATUS (*recv)(struct socket_context *sock, void *buf,
+			 size_t wantlen, size_t *nread, uint32_t flags);
+	NTSTATUS (*send)(struct socket_context *sock, 
+			 const DATA_BLOB *blob, size_t *sendlen, uint32_t flags);
 
 	void (*close)(struct socket_context *sock);