diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2005-03-22 08:00:45 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 13:11:11 -0500 |
| commit | 645711c602313940dcf80ec786557920ecfbf884 (patch) | |
| tree | 77c5f5c5f1285677eaaf7a3fa62bf0b2540e153f /source4/libnet | |
| parent | 376b03ebd895b221b70058ee18bea50587388182 (diff) | |
| download | samba-645711c602313940dcf80ec786557920ecfbf884.tar.gz samba-645711c602313940dcf80ec786557920ecfbf884.tar.bz2 samba-645711c602313940dcf80ec786557920ecfbf884.zip | |
r5941: Commit this patch much earlier than I would normally prefer, but metze needs a working tree...
The main volume of this patch was what I started working on today:
- Cleans up memory handling around DCE/RPC pipes, to have a parent talloc context.
- Uses sepereate inner loops for some of the DCE/RPC tests
The other and more important part of this patch fixes issues
surrounding the new credentials framwork:
This makes the struct cli_credentials always a talloc() structure,
rather than on the stack. Parts of the cli_credentials code already
assumed this.
There were other issues, particularly in the DCERPC over SMB handling,
as well as little things that had to be tidied up before test_w2k3.sh
would start to pass.
Andrew Bartlett
(This used to be commit 0453f9d05d2e336fba1f85dbf2718d01fa2bf778)
Diffstat (limited to 'source4/libnet')
| -rw-r--r-- | source4/libnet/libnet_join.c | 2 | ||||
| -rw-r--r-- | source4/libnet/libnet_passwd.c | 4 | ||||
| -rw-r--r-- | source4/libnet/libnet_rpc.c | 3 | ||||
| -rw-r--r-- | source4/libnet/libnet_time.c | 2 |
4 files changed, 6 insertions, 5 deletions
diff --git a/source4/libnet/libnet_join.c b/source4/libnet/libnet_join.c index f8acac8fb2..2dcffd93e1 100644 --- a/source4/libnet/libnet_join.c +++ b/source4/libnet/libnet_join.c @@ -287,7 +287,7 @@ static NTSTATUS libnet_JoinDomain_samr(struct libnet_context *ctx, disconnect: /* close connection */ - dcerpc_pipe_close(c.pdc.out.dcerpc_pipe); + talloc_free(c.pdc.out.dcerpc_pipe); return status; } diff --git a/source4/libnet/libnet_passwd.c b/source4/libnet/libnet_passwd.c index 41d70d8208..9613df75f3 100644 --- a/source4/libnet/libnet_passwd.c +++ b/source4/libnet/libnet_passwd.c @@ -247,7 +247,7 @@ ChangePasswordUser: #endif disconnect: /* close connection */ - dcerpc_pipe_close(c.pdc.out.dcerpc_pipe); + talloc_free(c.pdc.out.dcerpc_pipe); return status; } @@ -631,7 +631,7 @@ static NTSTATUS libnet_SetPassword_samr(struct libnet_context *ctx, TALLOC_CTX * disconnect: /* close connection */ - dcerpc_pipe_close(c.pdc.out.dcerpc_pipe); + talloc_free(c.pdc.out.dcerpc_pipe); return status; } diff --git a/source4/libnet/libnet_rpc.c b/source4/libnet/libnet_rpc.c index 7e941aac76..1f1812e261 100644 --- a/source4/libnet/libnet_rpc.c +++ b/source4/libnet/libnet_rpc.c @@ -97,7 +97,8 @@ static NTSTATUS libnet_rpc_connect_standard(struct libnet_context *ctx, TALLOC_C binding = talloc_asprintf(mem_ctx, "ncacn_np:%s", r->standard.in.server_name); - status = dcerpc_pipe_connect(&r->standard.out.dcerpc_pipe, + status = dcerpc_pipe_connect(mem_ctx, + &r->standard.out.dcerpc_pipe, binding, r->standard.in.dcerpc_iface_uuid, r->standard.in.dcerpc_iface_version, diff --git a/source4/libnet/libnet_time.c b/source4/libnet/libnet_time.c index ddf26876b9..b8f4cb7a86 100644 --- a/source4/libnet/libnet_time.c +++ b/source4/libnet/libnet_time.c @@ -88,7 +88,7 @@ static NTSTATUS libnet_RemoteTOD_srvsvc(struct libnet_context *ctx, TALLOC_CTX * disconnect: /* close connection */ - dcerpc_pipe_close(c.standard.out.dcerpc_pipe); + talloc_free(c.standard.out.dcerpc_pipe); return status; } |