summaryrefslogtreecommitdiff
path: root/source4/scripting/ejs
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2005-12-28 03:04:40 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 13:47:52 -0500
commite4dbcc0d5d6c9c68a7f3c437611b726f9f0211cf (patch)
treecc0456ffcb6dbb4627dd84048f2a22c5efe2a162 /source4/scripting/ejs
parent1f700876633c1f96bfc38d366dd0d5571aaa8696 (diff)
downloadsamba-e4dbcc0d5d6c9c68a7f3c437611b726f9f0211cf.tar.gz
samba-e4dbcc0d5d6c9c68a7f3c437611b726f9f0211cf.tar.bz2
samba-e4dbcc0d5d6c9c68a7f3c437611b726f9f0211cf.zip
r12531: 'make quicktest' was taking 15 minutes on my system due to failing DNS
lookups in load_interfaces(). The reason was my eth0 interface was down, and it was being interpreted as a DNS name. This patch changes load_interfaces() to happening automatically when interfaces are first needed instead of on the startup of every samba binary. This means that (for example) ldbadd doesn't call load_interfaces(), which means no slow DNS lookups. I also reduced the number of static globals in interface.c to 1, and changed from malloc to talloc When you want to force a reload of the interfaces list, you now call unload_interfaces(), which means the next call that needs the interfaces list will reload it (This used to be commit f79d90bd1364b970adb2981b2572e77066431f1e)
Diffstat (limited to 'source4/scripting/ejs')
-rw-r--r--source4/scripting/ejs/smbcalls_config.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/scripting/ejs/smbcalls_config.c b/source4/scripting/ejs/smbcalls_config.c
index a64d57a359..b0b1420ba2 100644
--- a/source4/scripting/ejs/smbcalls_config.c
+++ b/source4/scripting/ejs/smbcalls_config.c
@@ -188,7 +188,7 @@ static int ejs_lpReload(MprVarHandle eid, int argc, char **argv)
{
BOOL ret = lp_load();
if (ret) {
- load_interfaces();
+ unload_interfaces();
}
mpr_Return(eid, mprCreateBoolVar(ret));
return 0;