Modifications extending functionality of newuser cmd and new net group set of commands for group related operations on ldb

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>

1 files changed, 5 insertions, 1 deletions

diff --git a/source4/scripting/python/samba/netcmd/group.py b/source4/scripting/python/samba/netcmd/group.py
index 3d85a17390..41506bb205 100644
--- a/source4/scripting/python/samba/netcmd/group.py
+++ b/source4/scripting/python/samba/netcmd/group.py
@@ -70,7 +70,7 @@ class cmd_group_add(Command):
             versionopts=None, H=None, groupou=None, group_scope=None,
             group_type=None, description=None, mail_address=None, notes=None):
 
-        if cmp((group_type or "Security"), "Security") == 0:
+        if (group_type or "Security") == "Security":
               gtype = security_group.get(group_scope, GTYPE_SECURITY_GLOBAL_GROUP)
         else:
               gtype = distribution_group.get(group_scope, GTYPE_DISTRIBUTION_GLOBAL_GROUP)
@@ -87,6 +87,7 @@ class cmd_group_add(Command):
             raise CommandError('Failed to create group "%s" : %s' % (
                 groupname, msg))
 
+
 class cmd_group_delete(Command):
     """Delete a group"""
 
@@ -117,6 +118,7 @@ class cmd_group_delete(Command):
             raise CommandError('Failed to remove group "%s": %s' % (
                 groupname , msg))
 
+
 class cmd_group_add_members(Command):
     """Add (comma-separated list of) group members"""
 
@@ -148,6 +150,7 @@ class cmd_group_add_members(Command):
             raise CommandError('Failed to add members "%s" to group "%s": %s' % (
                 listofmembers, groupname , msg))
 
+
 class cmd_group_remove_members(Command):
     """Remove (comma-separated list of) group members"""
 
@@ -179,6 +182,7 @@ class cmd_group_remove_members(Command):
             raise CommandError('Failed to remove members "%s" from group "%s": %s' % (
                 listofmembers, groupname , msg))
 
+
 class cmd_group(SuperCommand):
     """Group management"""