diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2008-09-05 16:45:10 +1000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2008-09-05 16:45:10 +1000 |
| commit | 059cd93497c4c81d6ab957144beb6ae58e1638dc (patch) | |
| tree | f2c57ec63c9e2b2b13ff8b25ea32c649484d5503 /source4/smb_server/smb/signing.c | |
| parent | b7a1640b38e3f9bef6a031fd120fb0365801e531 (diff) | |
| download | samba-059cd93497c4c81d6ab957144beb6ae58e1638dc.tar.gz samba-059cd93497c4c81d6ab957144beb6ae58e1638dc.tar.bz2 samba-059cd93497c4c81d6ab957144beb6ae58e1638dc.zip | |
Move our DC to implement mandetory signing.
(this does not change the file server role, and only really changes
what 'server signing = auto' means)
Optional signing really isn't any benifit to network security.
In doing so, allow anonymous clients (if permitted by policy) to log
in without signing, as Samba3 does not sign these connections (which
would use an all-zero key, so pointless).
Andrew Bartlett
(This used to be commit 468bf839c500ed1a26ab9a358ee64a4c0a695797)
Diffstat (limited to 'source4/smb_server/smb/signing.c')
| -rw-r--r-- | source4/smb_server/smb/signing.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/source4/smb_server/smb/signing.c b/source4/smb_server/smb/signing.c index 186f5548ab..ee4531c8f6 100644 --- a/source4/smb_server/smb/signing.c +++ b/source4/smb_server/smb/signing.c @@ -77,7 +77,8 @@ bool smbsrv_setup_signing(struct smbsrv_connection *smb_conn, void smbsrv_signing_restart(struct smbsrv_connection *smb_conn, DATA_BLOB *session_key, - DATA_BLOB *response) + DATA_BLOB *response, + bool authenticated_session) { if (!smb_conn->signing.seen_valid) { DEBUG(5, ("Client did not send a valid signature on " @@ -85,7 +86,9 @@ void smbsrv_signing_restart(struct smbsrv_connection *smb_conn, /* force things back on (most clients do not sign this packet)... */ smbsrv_setup_signing(smb_conn, session_key, response); smb_conn->signing.next_seq_num = 2; - if (smb_conn->signing.mandatory_signing) { + + /* If mandetory_signing is set, and this was an authenticated logon, then force on */ + if (smb_conn->signing.mandatory_signing && authenticated_session) { DEBUG(5, ("Configured for mandatory signing, 'good packet seen' forced on\n")); /* if this is mandatory, then * pretend we have seen a @@ -117,6 +120,7 @@ bool smbsrv_init_signing(struct smbsrv_connection *smb_conn) case SMB_SIGNING_AUTO: if (lp_server_role(smb_conn->lp_ctx) == ROLE_DOMAIN_CONTROLLER) { smb_conn->signing.allow_smb_signing = true; + smb_conn->signing.mandatory_signing = true; } else { smb_conn->signing.allow_smb_signing = false; } |