s4/torture: Port SMBv1 Change Notify tests to SMBv2

* Ported all tests from raw/notify.c to smb2/notify.c
* Parameterized the max_buffer_size so it can be set on a
  per-target basis.
* Fixed CHECK macros to use torture_result
* Created a SMB2-NOTIFY test suite

2 files changed, 1829 insertions, 42 deletions

diff --git a/source4/torture/smb2/notify.c b/source4/torture/smb2/notify.c
index 5cf580a95e..60a646869f 100644
--- a/source4/torture/smb2/notify.c
+++ b/source4/torture/smb2/notify.c
@@ -1,20 +1,21 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
 
    SMB2 notify test suite
 
    Copyright (C) Stefan Metzmacher 2006
-   
+   Copyright (C) Andrew Tridgell 2009
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
@@ -25,59 +26,77 @@
 
 #include "torture/torture.h"
 #include "torture/smb2/proto.h"
+#include "librpc/gen_ndr/ndr_security.h"
+#include "libcli/security/security.h"
+#include "torture/util.h"
+
+#include "system/filesys.h"
+#include "auth/credentials/credentials.h"
+#include "lib/cmdline/popt_common.h"
+#include "librpc/gen_ndr/security.h"
 
 #include "lib/events/events.h"
 
+#include "libcli/raw/libcliraw.h"
+#include "libcli/raw/raw_proto.h"
+#include "libcli/libcli.h"
+
 #define CHECK_STATUS(status, correct) do { \
 	if (!NT_STATUS_EQUAL(status, correct)) { \
-		printf("(%s) Incorrect status %s - should be %s\n", \
+		torture_result(torture, TORTURE_FAIL, \
+		       "(%s) Incorrect status %s - should be %s\n", \
 		       __location__, nt_errstr(status), nt_errstr(correct)); \
 		ret = false; \
 		goto done; \
 	}} while (0)
 
-#define CHECK_VALUE(v, correct) do { \
+#define CHECK_VAL(v, correct) do { \
 	if ((v) != (correct)) { \
-		printf("(%s) Incorrect value %s=%d - should be %d\n", \
-		       __location__, #v, v, correct); \
+		torture_result(torture, TORTURE_FAIL, \
+		       "(%s) wrong value for %s  0x%x should be 0x%x\n", \
+		       __location__, #v, (int)v, (int)correct); \
 		ret = false; \
 		goto done; \
 	}} while (0)
 
 #define CHECK_WIRE_STR(field, value) do { \
 	if (!field.s || strcmp(field.s, value)) { \
-		printf("(%s) %s [%s] != %s\n", \
-			  __location__, #field, field.s, value); \
+		torture_result(torture, TORTURE_FAIL, \
+			"(%s) %s [%s] != %s\n",  __location__, #field, \
+			field.s, value); \
 		ret = false; \
 		goto done; \
 	}} while (0)
 
+#define BASEDIR "test_notify"
 #define FNAME "smb2-notify01.dat"
 
-#define TARGET_IS_WIN7(_tctx) (torture_setting_bool(_tctx, "win7", false))
-
-static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *tree)
+static bool test_valid_request(struct torture_context *torture,
+			       struct smb2_tree *tree)
 {
 	bool ret = true;
 	NTSTATUS status;
 	struct smb2_handle dh;
 	struct smb2_notify n;
 	struct smb2_request *req;
-	uint32_t max_buffer_size = 0x00080000;
+	uint32_t max_buffer_size;
 
-	if (TARGET_IS_WIN7(tctx)) {
-		max_buffer_size = 0x00010000;
-	}
+	torture_comment(torture, "TESTING VALIDITY OF CHANGE NOTIFY REQUEST\n");
 
 	smb2_util_unlink(tree, FNAME);
 
 	status = smb2_util_roothandle(tree, &dh);
 	CHECK_STATUS(status, NT_STATUS_OK);
 
+	/* 0x00080000 is the default max buffer size for Windows servers
+	 * pre-Win7 */
+	max_buffer_size = torture_setting_ulong(torture, "cn_max_buffer_size",
+						0x00080000);
+
 	n.in.recursive		= 0x0000;
 	n.in.buffer_size	= max_buffer_size;
 	n.in.file.handle	= dh;
-	n.in.completion_filter	= 0x00000FFF;
+	n.in.completion_filter	= FILE_NOTIFY_CHANGE_ALL;
 	n.in.unknown		= 0x00000000;
 	req = smb2_notify_send(tree, &n);
 
@@ -90,13 +109,13 @@ static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *t
 	status = torture_setup_complex_file(tree, FNAME);
 	CHECK_STATUS(status, NT_STATUS_OK);
 
-	status = smb2_notify_recv(req, tctx, &n);
+	status = smb2_notify_recv(req, torture, &n);
 	CHECK_STATUS(status, NT_STATUS_OK);
-	CHECK_VALUE(n.out.num_changes, 1);
-	CHECK_VALUE(n.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_VAL(n.out.num_changes, 1);
+	CHECK_VAL(n.out.changes[0].action, NOTIFY_ACTION_ADDED);
 	CHECK_WIRE_STR(n.out.changes[0].name, FNAME);
 
-	/* 
+	/*
 	 * if the change response doesn't fit in the buffer
 	 * NOTIFY_ENUM_DIR is returned.
 	 */
@@ -112,10 +131,10 @@ static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *t
 	status = torture_setup_complex_file(tree, FNAME);
 	CHECK_STATUS(status, NT_STATUS_OK);
 
-	status = smb2_notify_recv(req, tctx, &n);
+	status = smb2_notify_recv(req, torture, &n);
 	CHECK_STATUS(status, STATUS_NOTIFY_ENUM_DIR);
 
-	/* 
+	/*
 	 * if the change response fits in the buffer we get
 	 * NT_STATUS_OK again
 	 */
@@ -131,14 +150,14 @@ static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *t
 	status = torture_setup_complex_file(tree, FNAME);
 	CHECK_STATUS(status, NT_STATUS_OK);
 
-	status = smb2_notify_recv(req, tctx, &n);
+	status = smb2_notify_recv(req, torture, &n);
 	CHECK_STATUS(status, NT_STATUS_OK);
-	CHECK_VALUE(n.out.num_changes, 3);
-	CHECK_VALUE(n.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_VAL(n.out.num_changes, 3);
+	CHECK_VAL(n.out.changes[0].action, NOTIFY_ACTION_REMOVED);
 	CHECK_WIRE_STR(n.out.changes[0].name, FNAME);
-	CHECK_VALUE(n.out.changes[1].action, NOTIFY_ACTION_ADDED);
+	CHECK_VAL(n.out.changes[1].action, NOTIFY_ACTION_ADDED);
 	CHECK_WIRE_STR(n.out.changes[1].name, FNAME);
-	CHECK_VALUE(n.out.changes[2].action, NOTIFY_ACTION_MODIFIED);
+	CHECK_VAL(n.out.changes[2].action, NOTIFY_ACTION_MODIFIED);
 	CHECK_WIRE_STR(n.out.changes[2].name, FNAME);
 
 	/* if the first notify returns NOTIFY_ENUM_DIR, all do */
@@ -150,7 +169,7 @@ static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *t
 	n.in.recursive		= 0x0000;
 	n.in.buffer_size	= 0x00000001;
 	n.in.file.handle	= dh;
-	n.in.completion_filter	= 0x00000FFF;
+	n.in.completion_filter	= FILE_NOTIFY_CHANGE_ALL;
 	n.in.unknown		= 0x00000000;
 	req = smb2_notify_send(tree, &n);
 
@@ -163,10 +182,10 @@ static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *t
 	status = torture_setup_complex_file(tree, FNAME);
 	CHECK_STATUS(status, NT_STATUS_OK);
 
-	status = smb2_notify_recv(req, tctx, &n);
+	status = smb2_notify_recv(req, torture, &n);
 	CHECK_STATUS(status, STATUS_NOTIFY_ENUM_DIR);
 
-	n.in.buffer_size	= max_buffer_size;
+	n.in.buffer_size        = max_buffer_size;
 	req = smb2_notify_send(tree, &n);
 	while (!req->cancel.can_cancel && req->state <= SMB2_REQUEST_RECV) {
 		if (event_loop_once(req->transport->socket->event.ctx) != 0) {
@@ -177,35 +196,1803 @@ static bool test_valid_request(struct torture_context *tctx, struct smb2_tree *t
 	status = torture_setup_complex_file(tree, FNAME);
 	CHECK_STATUS(status, NT_STATUS_OK);
 
-	status = smb2_notify_recv(req, tctx, &n);
+	status = smb2_notify_recv(req, torture, &n);
 	CHECK_STATUS(status, STATUS_NOTIFY_ENUM_DIR);
 
 	/* if the buffer size is too large, we get invalid parameter */
 	n.in.recursive		= 0x0000;
 	n.in.buffer_size	= max_buffer_size + 1;
 	n.in.file.handle	= dh;
-	n.in.completion_filter	= 0x00000FFF;
+	n.in.completion_filter	= FILE_NOTIFY_CHANGE_ALL;
 	n.in.unknown		= 0x00000000;
 	req = smb2_notify_send(tree, &n);
-	status = smb2_notify_recv(req, tctx, &n);
+	status = smb2_notify_recv(req, torture, &n);
 	CHECK_STATUS(status, NT_STATUS_INVALID_PARAMETER);
 
 done:
 	return ret;
 }
 
-/* basic testing of SMB2 notify
+/*
+   basic testing of change notify on directories
 */
-bool torture_smb2_notify(struct torture_context *torture)
+static bool torture_smb2_notify_dir(struct torture_context *torture,
+			      struct smb2_tree *tree1,
+			      struct smb2_tree *tree2)
 {
-	struct smb2_tree *tree;
 	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	union smb_close cl;
+	int i, count;
+	struct smb2_handle h1, h2;
+	struct smb2_request *req, *req2;
+	const char *fname = BASEDIR "\\subdir-name";
+	extern int torture_numops;
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY ON DIRECTORIES\n");
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree1, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN;
+	io.smb2.in.desired_access = SEC_RIGHTS_FILE_READ;
+	status = smb2_create(tree1, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h2 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	torture_comment(torture, "testing notify cancel\n");
+
+	req = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_cancel(req);
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	torture_comment(torture, "testing notify mkdir\n");
+
+	req = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_util_mkdir(tree2, fname);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "testing notify rmdir\n");
+
+	req = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_util_rmdir(tree2, fname);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture,
+		"testing notify mkdir - rmdir - mkdir - rmdir\n");
 
-	if (!torture_smb2_connection(torture, &tree)) {
-		return false;
+	smb2_util_mkdir(tree2, fname);
+	smb2_util_rmdir(tree2, fname);
+	smb2_util_mkdir(tree2, fname);
+	smb2_util_rmdir(tree2, fname);
+	msleep(200);
+	req = smb2_notify_send(tree1, &(notify.smb2));
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 4);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+	CHECK_VAL(notify.smb2.out.changes[1].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[1].name, "subdir-name");
+	CHECK_VAL(notify.smb2.out.changes[2].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[2].name, "subdir-name");
+	CHECK_VAL(notify.smb2.out.changes[3].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[3].name, "subdir-name");
+
+	count = torture_numops;
+	torture_comment(torture,
+		"testing buffered notify on create of %d files\n", count);
+	for (i=0;i<count;i++) {
+		struct smb2_handle h12;
+		char *fname = talloc_asprintf(torture, BASEDIR "\\test%d.txt",
+					      i);
+
+		ZERO_STRUCT(io.smb2);
+		io.generic.level = RAW_OPEN_SMB2;
+	        io.smb2.in.create_flags = 0;
+		io.smb2.in.desired_access = SEC_FILE_ALL;
+	        io.smb2.in.create_options =
+		    NTCREATEX_OPTIONS_NON_DIRECTORY_FILE;
+		io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	        io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+					NTCREATEX_SHARE_ACCESS_WRITE;
+		io.smb2.in.alloc_size = 0;
+	        io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+		io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	        io.smb2.in.security_flags = 0;
+		io.smb2.in.fname = fname;
+
+		status = smb2_create(tree1, torture, &(io.smb2));
+		if (!NT_STATUS_EQUAL(status, NT_STATUS_OK)) {
+			torture_comment(torture, "Failed to create %s \n",
+			       fname);
+			ret = false;
+			goto done;
+		}
+		h12 = io.smb2.out.file.handle;
+		talloc_free(fname);
+		smb2_util_close(tree1, h12);
+	}
+
+	/* (1st notify) setup a new notify on a different directory handle.
+	   This new notify won't see the events above. */
+	notify.smb2.in.file.handle = h2;
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+
+	/* (2nd notify) whereas this notify will see the above buffered events,
+	   and it directly returns the buffered events */
+	notify.smb2.in.file.handle = h1;
+	req = smb2_notify_send(tree1, &(notify.smb2));
+
+	status = smb2_util_unlink(tree1, BASEDIR "\\nonexistant.txt");
+	CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
+
+	/* (1st unlink) as the 2nd notify directly returns,
+	   this unlink is only seen by the 1st notify and
+	   the 3rd notify (later) */
+	torture_comment(torture,
+		"testing notify on unlink for the first file\n");
+	status = smb2_util_unlink(tree2, BASEDIR "\\test0.txt");
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	/* receive the reply from the 2nd notify */
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, count);
+	for (i=1;i<count;i++) {
+		CHECK_VAL(notify.smb2.out.changes[i].action,
+			  NOTIFY_ACTION_ADDED);
 	}
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "test0.txt");
+
+	torture_comment(torture, "and now from the 1st notify\n");
+	status = smb2_notify_recv(req2, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "test0.txt");
+
+	torture_comment(torture,
+		"(3rd notify) this notify will only see the 1st unlink\n");
+	req = smb2_notify_send(tree1, &(notify.smb2));
+
+	status = smb2_util_unlink(tree1, BASEDIR "\\nonexistant.txt");
+	CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
+
+	for (i=1;i<count;i++) {
+		char *fname = talloc_asprintf(torture,
+			      BASEDIR "\\test%d.txt", i);
+		status = smb2_util_unlink(tree2, fname);
+		CHECK_STATUS(status, NT_STATUS_OK);
+		talloc_free(fname);
+	}
+
+	/* receive the 3rd notify */
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "test0.txt");
+
+	/* and we now see the rest of the unlink calls on both
+	 * directory handles */
+	notify.smb2.in.file.handle = h1;
+	sleep(3);
+	req = smb2_notify_send(tree1, &(notify.smb2));
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, count-1);
+	for (i=0;i<notify.smb2.out.num_changes;i++) {
+		CHECK_VAL(notify.smb2.out.changes[i].action,
+			  NOTIFY_ACTION_REMOVED);
+	}
+	notify.smb2.in.file.handle = h2;
+	req = smb2_notify_send(tree1, &(notify.smb2));
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, count-1);
+	for (i=0;i<notify.smb2.out.num_changes;i++) {
+		CHECK_VAL(notify.smb2.out.changes[i].action,
+			  NOTIFY_ACTION_REMOVED);
+	}
+
+	torture_comment(torture,
+	"testing if a close() on the dir handle triggers the notify reply\n");
 
-	ret &= test_valid_request(torture, tree);
+	notify.smb2.in.file.handle = h1;
+	req = smb2_notify_send(tree1, &(notify.smb2));
 
+	ZERO_STRUCT(cl.smb2);
+	cl.smb2.level = RAW_CLOSE_SMB2;
+	cl.smb2.in.file.handle = h1;
+	status = smb2_close(tree1, &(cl.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, STATUS_NOTIFY_CLEANUP);
+	CHECK_VAL(notify.smb2.out.num_changes, 9);
+
+done:
+	smb2_util_close(tree1, h1);
+	smb2_util_close(tree1, h2);
+	smb2_deltree(tree1, BASEDIR);
 	return ret;
 }
+
+static struct smb2_handle custom_smb2_create(struct smb2_tree *tree,
+						struct torture_context *torture,
+						struct smb2_create *smb2)
+{
+	struct smb2_handle h1;
+	bool ret = true;
+	NTSTATUS status;
+	smb2_deltree(tree, smb2->in.fname);
+	status = smb2_create(tree, torture, smb2);
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = smb2->out.file.handle;
+done:
+	return h1;
+}
+
+/*
+   testing of recursive change notify
+*/
+
+static bool torture_smb2_notify_recursive(struct torture_context *torture,
+				struct smb2_tree *tree1,
+				struct smb2_tree *tree2)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io, io1;
+	union smb_setfileinfo sinfo;
+	struct smb2_handle h1;
+	struct smb2_request *req1, *req2;
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY WITH RECURSION\n");
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree1, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify, on file or directory name
+	   changes. Setup both with and without recursion */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME |
+				FILE_NOTIFY_CHANGE_ATTRIBUTES |
+				FILE_NOTIFY_CHANGE_CREATION;
+	notify.smb2.in.file.handle = h1;
+
+	notify.smb2.in.recursive = true;
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_cancel(req1);
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	notify.smb2.in.recursive = false;
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_cancel(req2);
+	status = smb2_notify_recv(req2, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	ZERO_STRUCT(io1.smb2);
+	io1.generic.level = RAW_OPEN_SMB2;
+	io1.smb2.in.create_flags = NTCREATEX_FLAGS_EXTENDED;
+	io1.smb2.in.desired_access = SEC_RIGHTS_FILE_READ |
+				SEC_RIGHTS_FILE_WRITE|
+				SEC_RIGHTS_FILE_ALL;
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io1.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io1.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE |
+				NTCREATEX_SHARE_ACCESS_DELETE;
+	io1.smb2.in.alloc_size = 0;
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
+	io1.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io1.smb2.in.security_flags = 0;
+	io1.smb2.in.fname = BASEDIR "\\subdir-name";
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	smb2_util_close(tree2, io1.smb2.out.file.handle);
+
+	io1.smb2.in.fname = BASEDIR "\\subdir-name\\subname1";
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	ZERO_STRUCT(sinfo);
+	sinfo.rename_information.level = RAW_SFILEINFO_RENAME_INFORMATION;
+	sinfo.rename_information.in.file.handle = io1.smb2.out.file.handle;
+	sinfo.rename_information.in.overwrite = 0;
+	sinfo.rename_information.in.root_fid = 0;
+	sinfo.rename_information.in.new_name =
+				BASEDIR "\\subdir-name\\subname1-r";
+	status = smb2_setinfo_file(tree2, &sinfo);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_NON_DIRECTORY_FILE;
+	io1.smb2.in.fname = BASEDIR "\\subdir-name\\subname2";
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	ZERO_STRUCT(sinfo);
+	sinfo.rename_information.level = RAW_SFILEINFO_RENAME_INFORMATION;
+	sinfo.rename_information.in.file.handle = io1.smb2.out.file.handle;
+	sinfo.rename_information.in.overwrite = true;
+	sinfo.rename_information.in.root_fid = 0;
+	sinfo.rename_information.in.new_name = BASEDIR "\\subname2-r";
+	status = smb2_setinfo_file(tree2, &sinfo);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	io1.smb2.in.fname = BASEDIR "\\subname2-r";
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_OPEN;
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	ZERO_STRUCT(sinfo);
+	sinfo.rename_information.level = RAW_SFILEINFO_RENAME_INFORMATION;
+	sinfo.rename_information.in.file.handle = io1.smb2.out.file.handle;
+	sinfo.rename_information.in.overwrite = true;
+	sinfo.rename_information.in.root_fid = 0;
+	sinfo.rename_information.in.new_name = BASEDIR "\\subname3-r";
+	status = smb2_setinfo_file(tree2, &sinfo);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	notify.smb2.in.completion_filter = 0;
+	notify.smb2.in.recursive = true;
+	msleep(200);
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+
+	status = smb2_util_rmdir(tree2, BASEDIR "\\subdir-name\\subname1-r");
+	CHECK_STATUS(status, NT_STATUS_OK);
+	status = smb2_util_rmdir(tree2, BASEDIR "\\subdir-name");
+	CHECK_STATUS(status, NT_STATUS_OK);
+	status = smb2_util_unlink(tree2, BASEDIR "\\subname3-r");
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	notify.smb2.in.recursive = false;
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 9);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+	CHECK_VAL(notify.smb2.out.changes[1].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[1].name, "subdir-name\\subname1");
+	CHECK_VAL(notify.smb2.out.changes[2].action, NOTIFY_ACTION_OLD_NAME);
+	CHECK_WIRE_STR(notify.smb2.out.changes[2].name, "subdir-name\\subname1");
+	CHECK_VAL(notify.smb2.out.changes[3].action, NOTIFY_ACTION_NEW_NAME);
+	CHECK_WIRE_STR(notify.smb2.out.changes[3].name, "subdir-name\\subname1-r");
+	CHECK_VAL(notify.smb2.out.changes[4].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[4].name, "subdir-name\\subname2");
+	CHECK_VAL(notify.smb2.out.changes[5].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[5].name, "subdir-name\\subname2");
+	CHECK_VAL(notify.smb2.out.changes[6].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[6].name, "subname2-r");
+	CHECK_VAL(notify.smb2.out.changes[7].action, NOTIFY_ACTION_OLD_NAME);
+	CHECK_WIRE_STR(notify.smb2.out.changes[7].name, "subname2-r");
+	CHECK_VAL(notify.smb2.out.changes[8].action, NOTIFY_ACTION_NEW_NAME);
+	CHECK_WIRE_STR(notify.smb2.out.changes[8].name, "subname3-r");
+
+done:
+	smb2_deltree(tree1, BASEDIR);
+	return ret;
+}
+
+/*
+   testing of change notify mask change
+*/
+
+static bool torture_smb2_notify_mask_change(struct torture_context *torture,
+					    struct smb2_tree *tree1,
+					    struct smb2_tree *tree2)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io, io1;
+	struct smb2_handle h1;
+	struct smb2_request *req1, *req2;
+	union smb_setfileinfo sinfo;
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY WITH MASK CHANGE\n");
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree1, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify, on file or directory name
+	   changes. Setup both with and without recursion */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_ATTRIBUTES;
+	notify.smb2.in.file.handle = h1;
+
+	notify.smb2.in.recursive = true;
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+
+	smb2_cancel(req1);
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+
+	notify.smb2.in.recursive = false;
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+
+	smb2_cancel(req2);
+	status = smb2_notify_recv(req2, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	notify.smb2.in.recursive = true;
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+
+	/* Set to hidden then back again. */
+	ZERO_STRUCT(io1.smb2);
+	io1.generic.level = RAW_OPEN_SMB2;
+	io1.smb2.in.create_flags = 0;
+	io1.smb2.in.desired_access = SEC_RIGHTS_FILE_READ |
+				SEC_RIGHTS_FILE_WRITE|
+				SEC_RIGHTS_FILE_ALL;
+	io1.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io1.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE |
+				NTCREATEX_SHARE_ACCESS_DELETE;
+	io1.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io1.smb2.in.security_flags = 0;
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_NON_DIRECTORY_FILE;
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io1.smb2.in.fname = BASEDIR "\\tname1";
+
+	smb2_util_close(tree1,
+		custom_smb2_create(tree1, torture, &(io1.smb2)));
+	status = smb2_util_setatr(tree1, BASEDIR "\\tname1",
+				FILE_ATTRIBUTE_HIDDEN);
+	CHECK_STATUS(status, NT_STATUS_OK);
+	smb2_util_unlink(tree1, BASEDIR "\\tname1");
+
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_MODIFIED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "tname1");
+
+	/* Now try and change the mask to include other events.
+	 * This should not work - once the mask is set on a directory
+	 * h1 it seems to be fixed until the fnum is closed. */
+
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME |
+					FILE_NOTIFY_CHANGE_ATTRIBUTES |
+					FILE_NOTIFY_CHANGE_CREATION;
+	notify.smb2.in.recursive = true;
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+
+	notify.smb2.in.recursive = false;
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io1.smb2.in.fname = BASEDIR "\\subdir-name";
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	smb2_util_close(tree2, io1.smb2.out.file.handle);
+
+	ZERO_STRUCT(sinfo);
+	io1.smb2.in.fname = BASEDIR "\\subdir-name\\subname1";
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	sinfo.rename_information.level = RAW_SFILEINFO_RENAME_INFORMATION;
+	sinfo.rename_information.in.file.handle = io1.smb2.out.file.handle;
+	sinfo.rename_information.in.overwrite = true;
+	sinfo.rename_information.in.root_fid = 0;
+	sinfo.rename_information.in.new_name =
+				BASEDIR "\\subdir-name\\subname1-r";
+	status = smb2_setinfo_file(tree2, &sinfo);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	io1.smb2.in.fname = BASEDIR "\\subdir-name\\subname2";
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_NON_DIRECTORY_FILE;
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	sinfo.rename_information.in.file.handle = io1.smb2.out.file.handle;
+	sinfo.rename_information.in.new_name = BASEDIR "\\subname2-r";
+	status = smb2_setinfo_file(tree2, &sinfo);
+	CHECK_STATUS(status, NT_STATUS_OK);
+	smb2_util_close(tree2, io1.smb2.out.file.handle);
+
+	io1.smb2.in.fname = BASEDIR "\\subname2-r";
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_OPEN;
+	status = smb2_create(tree2, torture, &(io1.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	sinfo.rename_information.in.file.handle = io1.smb2.out.file.handle;
+	sinfo.rename_information.in.new_name = BASEDIR "\\subname3-r";
+	status = smb2_setinfo_file(tree2, &sinfo);
+	CHECK_STATUS(status, NT_STATUS_OK);
+	smb2_util_close(tree2, io1.smb2.out.file.handle);
+
+	status = smb2_util_rmdir(tree2, BASEDIR "\\subdir-name\\subname1-r");
+	CHECK_STATUS(status, NT_STATUS_OK);
+	status = smb2_util_rmdir(tree2, BASEDIR "\\subdir-name");
+	CHECK_STATUS(status, NT_STATUS_OK);
+	status = smb2_util_unlink(tree2, BASEDIR "\\subname3-r");
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_MODIFIED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subname2-r");
+
+	status = smb2_notify_recv(req2, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_MODIFIED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subname3-r");
+
+	if (!ret) {
+		goto done;
+	}
+
+done:
+	smb2_deltree(tree1, BASEDIR);
+	return ret;
+}
+
+/*
+   testing of mask bits for change notify
+*/
+
+static bool torture_smb2_notify_mask(struct torture_context *torture,
+				     struct smb2_tree *tree1,
+				     struct smb2_tree *tree2)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io, io1;
+	struct smb2_handle h1, h2;
+	uint32_t mask;
+	int i;
+	char c = 1;
+	struct timeval tv;
+	NTTIME t;
+	union smb_setfileinfo sinfo;
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY COMPLETION FILTERS\n");
+
+	tv = timeval_current_ofs(1000, 0);
+	t = timeval_to_nttime(&tv);
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.recursive = true;
+
+#define NOTIFY_MASK_TEST(test_name, setup, op, cleanup, Action, \
+			 expected, nchanges) \
+	do { \
+	do { for (mask=i=0;i<32;i++) { \
+		struct smb2_request *req; \
+		status = smb2_create(tree1, torture, &(io.smb2)); \
+		CHECK_STATUS(status, NT_STATUS_OK); \
+		h1 = io.smb2.out.file.handle; \
+		setup \
+		notify.smb2.in.file.handle = h1;	\
+		notify.smb2.in.completion_filter = (1<<i); \
+		/* cancel initial requests so the buffer is setup */	\
+		req = smb2_notify_send(tree1, &(notify.smb2)); \
+		smb2_cancel(req); \
+		status = smb2_notify_recv(req, torture, &(notify.smb2)); \
+		CHECK_STATUS(status, NT_STATUS_CANCELLED); \
+		/* send the change notify request */ \
+		req = smb2_notify_send(tree1, &(notify.smb2)); \
+		op \
+		msleep(200); smb2_cancel(req); \
+		status = smb2_notify_recv(req, torture, &(notify.smb2)); \
+		cleanup \
+		smb2_util_close(tree1, h1); \
+		if (NT_STATUS_EQUAL(status, NT_STATUS_CANCELLED)) continue; \
+		CHECK_STATUS(status, NT_STATUS_OK); \
+		/* special case to cope with file rename behaviour */ \
+		if (nchanges == 2 && notify.smb2.out.num_changes == 1 && \
+		    notify.smb2.out.changes[0].action == \
+			NOTIFY_ACTION_MODIFIED && \
+		    ((expected) & FILE_NOTIFY_CHANGE_ATTRIBUTES) && \
+		    Action == NOTIFY_ACTION_OLD_NAME) { \
+			torture_comment(torture, \
+				"(rename file special handling OK)\n"); \
+		} else if (nchanges != notify.smb2.out.num_changes) { \
+			torture_result(torture, TORTURE_FAIL, \
+			       "ERROR: nchanges=%d expected=%d "\
+			       "action=%d filter=0x%08x\n", \
+			       notify.smb2.out.num_changes, \
+			       nchanges, \
+			       notify.smb2.out.changes[0].action, \
+			       notify.smb2.in.completion_filter); \
+			ret = false; \
+		} else if (notify.smb2.out.changes[0].action != Action) { \
+			torture_result(torture, TORTURE_FAIL, \
+			       "ERROR: nchanges=%d action=%d " \
+			       "expectedAction=%d filter=0x%08x\n", \
+			       notify.smb2.out.num_changes, \
+			       notify.smb2.out.changes[0].action, \
+			       Action, \
+			       notify.smb2.in.completion_filter); \
+			ret = false; \
+		} else if (strcmp(notify.smb2.out.changes[0].name.s, \
+			   "tname1") != 0) { \
+			torture_result(torture, TORTURE_FAIL, \
+			       "ERROR: nchanges=%d action=%d " \
+			       "filter=0x%08x name=%s\n", \
+			       notify.smb2.out.num_changes, \
+			       notify.smb2.out.changes[0].action, \
+			       notify.smb2.in.completion_filter, \
+			       notify.smb2.out.changes[0].name.s);	\
+			ret = false; \
+		} \
+		mask |= (1<<i); \
+	} \
+	} while (0); \
+	} while (0);
+
+	torture_comment(torture, "testing mkdir\n");
+	NOTIFY_MASK_TEST("testing mkdir",;,
+			 smb2_util_mkdir(tree2, BASEDIR "\\tname1");,
+			 smb2_util_rmdir(tree2, BASEDIR "\\tname1");,
+			 NOTIFY_ACTION_ADDED,
+			 FILE_NOTIFY_CHANGE_DIR_NAME, 1);
+
+	torture_comment(torture, "testing create file\n");
+	ZERO_STRUCT(io1.smb2);
+	io1.generic.level = RAW_OPEN_SMB2;
+	io1.smb2.in.create_flags = 0;
+	io1.smb2.in.desired_access = SEC_FILE_ALL;
+	io1.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io1.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io1.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io1.smb2.in.security_flags = 0;
+	io1.smb2.in.create_options = NTCREATEX_OPTIONS_NON_DIRECTORY_FILE;
+	io1.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io1.smb2.in.fname = BASEDIR "\\tname1";
+
+	NOTIFY_MASK_TEST("testing create file",;,
+			 smb2_util_close(tree2, custom_smb2_create(tree2,
+						torture, &(io1.smb2)));,
+			 smb2_util_unlink(tree2, BASEDIR "\\tname1");,
+			 NOTIFY_ACTION_ADDED,
+			 FILE_NOTIFY_CHANGE_FILE_NAME, 1);
+
+	torture_comment(torture, "testing unlink\n");
+	NOTIFY_MASK_TEST("testing unlink",
+			 smb2_util_close(tree2, custom_smb2_create(tree2,
+						torture, &(io1.smb2)));,
+			 smb2_util_unlink(tree2, BASEDIR "\\tname1");,
+			 ;,
+			 NOTIFY_ACTION_REMOVED,
+			 FILE_NOTIFY_CHANGE_FILE_NAME, 1);
+
+	torture_comment(torture, "testing rmdir\n");
+	NOTIFY_MASK_TEST("testing rmdir",
+			 smb2_util_mkdir(tree2, BASEDIR "\\tname1");,
+			 smb2_util_rmdir(tree2, BASEDIR "\\tname1");,
+			 ;,
+			 NOTIFY_ACTION_REMOVED,
+			 FILE_NOTIFY_CHANGE_DIR_NAME, 1);
+
+	torture_comment(torture, "testing rename file\n");
+	ZERO_STRUCT(sinfo);
+	sinfo.rename_information.level = RAW_SFILEINFO_RENAME_INFORMATION;
+	sinfo.rename_information.in.file.handle = h1;
+	sinfo.rename_information.in.overwrite = true;
+	sinfo.rename_information.in.root_fid = 0;
+	sinfo.rename_information.in.new_name = BASEDIR "\\tname2";
+	NOTIFY_MASK_TEST("testing rename file",
+			 smb2_util_close(tree2, custom_smb2_create(tree2,
+						torture, &(io1.smb2)));,
+			 smb2_setinfo_file(tree2, &sinfo);,
+			 smb2_util_unlink(tree2, BASEDIR "\\tname2");,
+			 NOTIFY_ACTION_OLD_NAME,
+			 FILE_NOTIFY_CHANGE_FILE_NAME, 2);
+
+	torture_comment(torture, "testing rename dir\n");
+	ZERO_STRUCT(sinfo);
+	sinfo.rename_information.level = RAW_SFILEINFO_RENAME_INFORMATION;
+	sinfo.rename_information.in.file.handle = h1;
+	sinfo.rename_information.in.overwrite = true;
+	sinfo.rename_information.in.root_fid = 0;
+	sinfo.rename_information.in.new_name = BASEDIR "\\tname2";
+	NOTIFY_MASK_TEST("testing rename dir",
+		smb2_util_mkdir(tree2, BASEDIR "\\tname1");,
+		smb2_setinfo_file(tree2, &sinfo);,
+		smb2_util_rmdir(tree2, BASEDIR "\\tname2");,
+		NOTIFY_ACTION_OLD_NAME,
+		FILE_NOTIFY_CHANGE_DIR_NAME, 2);
+
+	torture_comment(torture, "testing set path attribute\n");
+	NOTIFY_MASK_TEST("testing set path attribute",
+		smb2_util_close(tree2, custom_smb2_create(tree2,
+				       torture, &(io.smb2)));,
+		smb2_util_setatr(tree2, BASEDIR "\\tname1",
+				 FILE_ATTRIBUTE_HIDDEN);,
+		smb2_util_unlink(tree2, BASEDIR "\\tname1");,
+		NOTIFY_ACTION_MODIFIED,
+		FILE_NOTIFY_CHANGE_ATTRIBUTES, 1);
+
+	torture_comment(torture, "testing set path write time\n");
+	ZERO_STRUCT(sinfo);
+	sinfo.generic.level = RAW_SFILEINFO_BASIC_INFORMATION;
+	sinfo.generic.in.file.handle = h1;
+	sinfo.basic_info.in.write_time = 1000;
+	NOTIFY_MASK_TEST("testing set path write time",
+		smb2_util_close(tree2, custom_smb2_create(tree2,
+				       torture, &(io1.smb2)));,
+		smb2_setinfo_file(tree2, &sinfo);,
+		smb2_util_unlink(tree2, BASEDIR "\\tname1");,
+		NOTIFY_ACTION_MODIFIED,
+		FILE_NOTIFY_CHANGE_LAST_WRITE, 1);
+
+	if (torture_setting_bool(torture, "samba3", false)) {
+		torture_comment(torture,
+		       "Samba3 does not yet support create times "
+		       "everywhere\n");
+	}
+	else {
+		ZERO_STRUCT(sinfo);
+	        sinfo.generic.level = RAW_SFILEINFO_BASIC_INFORMATION;
+		sinfo.generic.in.file.handle = h1;
+	        sinfo.basic_info.in.create_time = 0;
+		torture_comment(torture, "testing set file create time\n");
+		NOTIFY_MASK_TEST("testing set file create time",
+			smb2_create_complex_file(tree2,
+			BASEDIR "\\tname1", &h2);,
+			smb2_setinfo_file(tree2, &sinfo);,
+			(smb2_util_close(tree2, h2),
+			 smb2_util_unlink(tree2, BASEDIR "\\tname1"));,
+			NOTIFY_ACTION_MODIFIED,
+			FILE_NOTIFY_CHANGE_CREATION, 1);
+	}
+
+	ZERO_STRUCT(sinfo);
+	sinfo.generic.level = RAW_SFILEINFO_BASIC_INFORMATION;
+	sinfo.generic.in.file.handle = h1;
+	sinfo.basic_info.in.access_time = 0;
+	torture_comment(torture, "testing set file access time\n");
+	NOTIFY_MASK_TEST("testing set file access time",
+		smb2_create_complex_file(tree2, BASEDIR "\\tname1", &h2);,
+		smb2_setinfo_file(tree2, &sinfo);,
+		(smb2_util_close(tree2, h2),
+		smb2_util_unlink(tree2, BASEDIR "\\tname1"));,
+		NOTIFY_ACTION_MODIFIED,
+		FILE_NOTIFY_CHANGE_LAST_ACCESS, 1);
+
+	ZERO_STRUCT(sinfo);
+	sinfo.generic.level = RAW_SFILEINFO_BASIC_INFORMATION;
+	sinfo.generic.in.file.handle = h1;
+	sinfo.basic_info.in.change_time = 0;
+	torture_comment(torture, "testing set file change time\n");
+	NOTIFY_MASK_TEST("testing set file change time",
+		smb2_create_complex_file(tree2, BASEDIR "\\tname1", &h2);,
+		smb2_setinfo_file(tree2, &sinfo);,
+		(smb2_util_close(tree2, h2),
+		smb2_util_unlink(tree2, BASEDIR "\\tname1"));,
+		NOTIFY_ACTION_MODIFIED,
+		0, 1);
+
+
+	torture_comment(torture, "testing write\n");
+	NOTIFY_MASK_TEST("testing write",
+		smb2_create_complex_file(tree2, BASEDIR "\\tname1", &h2);,
+		smb2_util_write(tree2, h2, &c, 10000, 1);,
+		(smb2_util_close(tree2, h2),
+		smb2_util_unlink(tree2, BASEDIR "\\tname1"));,
+		NOTIFY_ACTION_MODIFIED,
+		0, 1);
+
+done:
+	smb2_deltree(tree1, BASEDIR);
+	return ret;
+}
+
+/*
+  basic testing of change notify on files
+*/
+static bool torture_smb2_notify_file(struct torture_context *torture,
+				struct smb2_tree *tree)
+{
+	NTSTATUS status;
+	bool ret = true;
+	union smb_open io;
+	union smb_close cl;
+	union smb_notify notify;
+	struct smb2_request *req;
+	struct smb2_handle h1;
+	const char *fname = BASEDIR "\\file.txt";
+
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY ON FILES\n");
+	status = torture_smb2_testdir(tree, BASEDIR, &h1);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
+	io.smb2.in.create_options = 0;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = fname;
+	status = smb2_create(tree, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_STREAM_NAME;
+	notify.smb2.in.recursive = false;
+
+	torture_comment(torture,
+	"testing if notifies on file handles are invalid (should be)\n");
+
+	req = smb2_notify_send(tree, &(notify.smb2));
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_INVALID_PARAMETER);
+
+	ZERO_STRUCT(cl.smb2);
+	cl.close.level = RAW_CLOSE_SMB2;
+	cl.close.in.file.handle = h1;
+	status = smb2_close(tree, &(cl.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	status = smb2_util_unlink(tree, fname);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+done:
+	smb2_deltree(tree, BASEDIR);
+	return ret;
+}
+/*
+  basic testing of change notifies followed by a tdis
+*/
+
+static bool torture_smb2_notify_tree_disconnect(
+		struct torture_context *torture,
+		struct smb2_tree *tree)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1;
+	struct smb2_request *req;
+
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY FOLLOWED BY "
+			"TREE-DISCONNECT\n");
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_cancel(req);
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+
+	status = smb2_tdis(tree);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	req = smb2_notify_send(tree, &(notify.smb2));
+
+	smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 0);
+
+done:
+	smb2_deltree(tree, BASEDIR);
+	return ret;
+}
+
+/*
+  basic testing of change notifies followed by a ulogoff
+*/
+
+static bool torture_smb2_notify_ulogoff(struct torture_context *torture,
+				struct smb2_tree *tree1,
+				struct smb2_tree *tree2)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1;
+	struct smb2_request *req;
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY FOLLOWED BY ULOGOFF\n");
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree2, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN;
+	status = smb2_create(tree2, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	req = smb2_notify_send(tree1, &(notify.smb2));
+
+	status = smb2_logoff(tree2->session);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_VAL(notify.smb2.out.num_changes, 0);
+
+done:
+	smb2_deltree(tree1, BASEDIR);
+	return ret;
+}
+
+static void tcp_dis_handler(struct smb2_transport *t, void *p)
+{
+	struct smb2_tree *tree = (struct smb2_tree *)p;
+	smb2_transport_dead(tree->session->transport,
+			NT_STATUS_LOCAL_DISCONNECT);
+	t = NULL;
+	tree = NULL;
+}
+
+/*
+  basic testing of change notifies followed by tcp disconnect
+*/
+
+static bool torture_smb2_notify_tcp_disconnect(
+		struct torture_context *torture,
+		struct smb2_tree *tree)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1;
+	struct smb2_request *req;
+
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+
+	torture_comment(torture,
+		"TESTING CHANGE NOTIFY FOLLOWED BY TCP DISCONNECT\n");
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_cancel(req);
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	notify.smb2.in.recursive = true;
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_transport_idle_handler(tree->session->transport,
+				tcp_dis_handler, 250, tree);
+	tree = NULL;
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_LOCAL_DISCONNECT);
+
+done:
+	return ret;
+}
+
+/*
+   test setting up two change notify requests on one handle
+*/
+
+static bool torture_smb2_notify_double(struct torture_context *torture,
+			struct smb2_tree *tree1,
+			struct smb2_tree *tree2)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1;
+	struct smb2_request *req1, *req2;
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+
+	torture_comment(torture,
+		"TESTING CHANGE NOTIFY TWICE ON ONE DIRECTORY\n");
+
+	/*
+	  get a handle on the directory
+	*/
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_RIGHTS_FILE_READ|
+				SEC_RIGHTS_FILE_WRITE|
+				SEC_RIGHTS_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree1, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_cancel(req1);
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+	smb2_cancel(req2);
+	status = smb2_notify_recv(req2, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	smb2_util_mkdir(tree2, BASEDIR "\\subdir-name");
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+	req2 = smb2_notify_send(tree1, &(notify.smb2));
+
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	smb2_util_mkdir(tree2, BASEDIR "\\subdir-name2");
+
+	status = smb2_notify_recv(req2, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name2");
+
+done:
+	smb2_deltree(tree1, BASEDIR);
+	return ret;
+}
+
+
+/*
+   test multiple change notifies at different depths and with/without recursion
+*/
+
+static bool torture_smb2_notify_tree(struct torture_context *torture,
+			     struct smb2_tree *tree)
+{
+	bool ret = true;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_request *req;
+	struct timeval tv;
+	struct {
+		const char *path;
+		bool recursive;
+		uint32_t filter;
+		int expected;
+		struct smb2_handle h1;
+		int counted;
+	} dirs[] = {
+		{BASEDIR "\\abc",               true, FILE_NOTIFY_CHANGE_NAME, 30 },
+		{BASEDIR "\\zqy",               true, FILE_NOTIFY_CHANGE_NAME, 8 },
+		{BASEDIR "\\atsy",              true, FILE_NOTIFY_CHANGE_NAME, 4 },
+		{BASEDIR "\\abc\\foo",          true,  FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\abc\\blah",         true,  FILE_NOTIFY_CHANGE_NAME, 13 },
+		{BASEDIR "\\abc\\blah",         false, FILE_NOTIFY_CHANGE_NAME, 7 },
+		{BASEDIR "\\abc\\blah\\a",      true, FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\abc\\blah\\b",      true, FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\abc\\blah\\c",      true, FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\abc\\fooblah",      true, FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\zqy\\xx",           true, FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\zqy\\yyy",          true, FILE_NOTIFY_CHANGE_NAME, 2 },
+		{BASEDIR "\\zqy\\..",           true, FILE_NOTIFY_CHANGE_NAME, 40 },
+		{BASEDIR,                       true, FILE_NOTIFY_CHANGE_NAME, 40 },
+		{BASEDIR,                       false,FILE_NOTIFY_CHANGE_NAME, 6 },
+		{BASEDIR "\\atsy",              false,FILE_NOTIFY_CHANGE_NAME, 4 },
+		{BASEDIR "\\abc",               true, FILE_NOTIFY_CHANGE_NAME, 24 },
+		{BASEDIR "\\abc",               false,FILE_NOTIFY_CHANGE_FILE_NAME, 0 },
+		{BASEDIR "\\abc",               true, FILE_NOTIFY_CHANGE_FILE_NAME, 0 },
+		{BASEDIR "\\abc",               true, FILE_NOTIFY_CHANGE_NAME, 24 },
+	};
+	int i;
+	NTSTATUS status;
+	bool all_done = false;
+
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+
+	torture_comment(torture, "TESTING NOTIFY FOR DIFFERENT DEPTHS\n");
+
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+	status = smb2_create(tree, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 20000;
+
+	/*
+	  setup the directory tree, and the notify buffer on each directory
+	*/
+	for (i=0;i<ARRAY_SIZE(dirs);i++) {
+		io.smb2.in.fname = dirs[i].path;
+		status = smb2_create(tree, torture, &(io.smb2));
+		CHECK_STATUS(status, NT_STATUS_OK);
+		dirs[i].h1 = io.smb2.out.file.handle;
+
+		notify.smb2.in.completion_filter = dirs[i].filter;
+		notify.smb2.in.file.handle = dirs[i].h1;
+		notify.smb2.in.recursive = dirs[i].recursive;
+		req = smb2_notify_send(tree, &(notify.smb2));
+		smb2_cancel(req);
+		status = smb2_notify_recv(req, torture, &(notify.smb2));
+		CHECK_STATUS(status, NT_STATUS_CANCELLED);
+	}
+
+	/* trigger 2 events in each dir */
+	for (i=0;i<ARRAY_SIZE(dirs);i++) {
+		char *path = talloc_asprintf(torture, "%s\\test.dir",
+					     dirs[i].path);
+		smb2_util_mkdir(tree, path);
+		smb2_util_rmdir(tree, path);
+		talloc_free(path);
+	}
+
+	/* give a bit of time for the events to propogate */
+	tv = timeval_current();
+
+	do {
+		/* count events that have happened in each dir */
+		for (i=0;i<ARRAY_SIZE(dirs);i++) {
+			notify.smb2.in.file.handle = dirs[i].h1;
+			req = smb2_notify_send(tree, &(notify.smb2));
+			smb2_cancel(req);
+			notify.smb2.out.num_changes = 0;
+			status = smb2_notify_recv(req, torture,
+				 &(notify.smb2));
+			dirs[i].counted += notify.smb2.out.num_changes;
+		}
+
+		all_done = true;
+
+		for (i=0;i<ARRAY_SIZE(dirs);i++) {
+			if (dirs[i].counted != dirs[i].expected) {
+				all_done = false;
+			}
+		}
+	} while (!all_done && timeval_elapsed(&tv) < 20);
+
+	torture_comment(torture, "took %.4f seconds to propogate all events\n",
+			timeval_elapsed(&tv));
+
+	for (i=0;i<ARRAY_SIZE(dirs);i++) {
+		if (dirs[i].counted != dirs[i].expected) {
+			torture_comment(torture,
+				"ERROR: i=%d expected %d got %d for '%s'\n",
+				i, dirs[i].expected, dirs[i].counted,
+				dirs[i].path);
+			ret = false;
+		}
+	}
+
+	/*
+	  run from the back, closing and deleting
+	*/
+	for (i=ARRAY_SIZE(dirs)-1;i>=0;i--) {
+		smb2_util_close(tree, dirs[i].h1);
+		smb2_util_rmdir(tree, dirs[i].path);
+	}
+
+done:
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+	return ret;
+}
+
+/*
+   Test response when cached server events exceed single NT NOTFIY response
+   packet size.
+*/
+
+static bool torture_smb2_notify_overflow(struct torture_context *torture,
+				struct smb2_tree *tree)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1, h2;
+	int count = 100;
+	struct smb2_request *req1;
+	int i;
+
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY EVENT OVERFLOW\n");
+
+	/* get a handle on the directory */
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+			    NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify, on name changes. */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_NTTRANS;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+
+	notify.smb2.in.recursive = true;
+	req1 = smb2_notify_send(tree, &(notify.smb2));
+
+	/* cancel initial requests so the buffer is setup */
+	smb2_cancel(req1);
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	/* open a lot of files, filling up the server side notify buffer */
+	torture_comment(torture,
+		"testing overflowed buffer notify on create of %d files\n",
+		count);
+
+	for (i=0;i<count;i++) {
+		char *fname = talloc_asprintf(torture,
+			      BASEDIR "\\test%d.txt", i);
+		union smb_open io1;
+		ZERO_STRUCT(io1.smb2);
+	        io1.generic.level = RAW_OPEN_SMB2;
+		io1.smb2.in.create_flags = 0;
+	        io1.smb2.in.desired_access = SEC_FILE_ALL;
+		io1.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+		io1.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	        io1.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				    NTCREATEX_SHARE_ACCESS_WRITE;
+	        io1.smb2.in.alloc_size = 0;
+	        io1.smb2.in.create_disposition = NTCREATEX_DISP_CREATE;
+	        io1.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	        io1.smb2.in.security_flags = 0;
+		io1.smb2.in.fname = fname;
+
+		h2 = custom_smb2_create(tree, torture, &(io1.smb2));
+		talloc_free(fname);
+		smb2_util_close(tree, h2);
+	}
+
+	req1 = smb2_notify_send(tree, &(notify.smb2));
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, STATUS_NOTIFY_ENUM_DIR);
+	CHECK_VAL(notify.smb2.out.num_changes, 0);
+
+done:
+	smb2_deltree(tree, BASEDIR);
+	return ret;
+}
+
+/*
+   Test if notifications are returned for changes to the base directory.
+   They shouldn't be.
+*/
+
+static bool torture_smb2_notify_basedir(struct torture_context *torture,
+				struct smb2_tree *tree1,
+				struct smb2_tree *tree2)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1;
+	struct smb2_request *req1;
+
+	smb2_deltree(tree1, BASEDIR);
+	smb2_util_rmdir(tree1, BASEDIR);
+
+	torture_comment(torture, "TESTING CHANGE NOTIFY BASEDIR EVENTS\n");
+
+	/* get a handle on the directory */
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+	    NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
+	io.smb2.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree1, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* create a test file that will also be modified */
+	io.smb2.in.fname = BASEDIR "\\tname1";
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_NON_DIRECTORY_FILE;
+	status =  smb2_create(tree2, torture, &(io.smb2));
+	CHECK_STATUS(status,NT_STATUS_OK);
+	smb2_util_close(tree2, io.smb2.out.file.handle);
+
+	/* ask for a change notify, on attribute changes. */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_ATTRIBUTES;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	req1 = smb2_notify_send(tree1, &(notify.smb2));
+
+	/* set attribute on the base dir */
+	smb2_util_setatr(tree2, BASEDIR, FILE_ATTRIBUTE_HIDDEN);
+
+	/* set attribute on a file to assure we receive a notification */
+	smb2_util_setatr(tree2, BASEDIR "\\tname1", FILE_ATTRIBUTE_HIDDEN);
+	msleep(200);
+
+	/* check how many responses were given, expect only 1 for the file */
+	status = smb2_notify_recv(req1, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_MODIFIED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "tname1");
+
+done:
+	smb2_deltree(tree1, BASEDIR);
+	return ret;
+}
+
+
+/*
+  create a secondary tree connect - used to test for a bug in Samba3 messaging
+  with change notify
+*/
+static struct smb2_tree *secondary_tcon(struct smb2_tree *tree,
+					struct torture_context *tctx)
+{
+	NTSTATUS status;
+	const char *share, *host;
+	struct smb2_tree *tree1;
+	union smb_tcon tcon;
+
+	share = torture_setting_string(tctx, "share", NULL);
+	host  = torture_setting_string(tctx, "host", NULL);
+
+	torture_comment(tctx,
+		"create a second tree context on the same session\n");
+	tree1 = smb2_tree_init(tree->session, tctx, false);
+
+	ZERO_STRUCT(tcon.smb2);
+	tcon.generic.level = RAW_TCON_SMB2;
+	tcon.smb2.in.path = talloc_asprintf(tctx, "\\\\%s\\%s", host, share);
+	status = smb2_tree_connect(tree, &(tcon.smb2));
+	if (!NT_STATUS_IS_OK(status)) {
+		talloc_free(tree);
+		torture_comment(tctx,"Failed to create secondary tree\n");
+		return NULL;
+	}
+
+	tree1->tid = tcon.smb2.out.tid;
+	torture_comment(tctx,"tid1=%d tid2=%d\n", tree->tid, tree1->tid);
+
+	return tree1;
+}
+
+
+/*
+   very simple change notify test
+*/
+static bool torture_smb2_notify_tcon(struct torture_context *torture,
+				  struct smb2_tree *tree)
+{
+	bool ret = true;
+	NTSTATUS status;
+	union smb_notify notify;
+	union smb_open io;
+	struct smb2_handle h1;
+	struct smb2_request *req = NULL;
+	struct smb2_tree *tree1 = NULL;
+	const char *fname = BASEDIR "\\subdir-name";
+
+	smb2_deltree(tree, BASEDIR);
+	smb2_util_rmdir(tree, BASEDIR);
+
+	torture_comment(torture, "TESTING SIMPLE CHANGE NOTIFY\n");
+
+	/*
+	  get a handle on the directory
+	*/
+
+	ZERO_STRUCT(io.smb2);
+	io.generic.level = RAW_OPEN_SMB2;
+	io.smb2.in.create_flags = 0;
+	io.smb2.in.desired_access = SEC_RIGHTS_FILE_ALL;
+	io.smb2.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+	io.smb2.in.file_attributes = FILE_ATTRIBUTE_NORMAL |
+				FILE_ATTRIBUTE_DIRECTORY;
+	io.smb2.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+				NTCREATEX_SHARE_ACCESS_WRITE;
+	io.smb2.in.alloc_size = 0;
+	io.smb2.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
+	io.smb2.in.impersonation_level = SMB2_IMPERSONATION_ANONYMOUS;
+	io.smb2.in.security_flags = 0;
+	io.smb2.in.fname = BASEDIR;
+
+	status = smb2_create(tree, torture, &(io.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	h1 = io.smb2.out.file.handle;
+
+	/* ask for a change notify,
+	   on file or directory name changes */
+	ZERO_STRUCT(notify.smb2);
+	notify.smb2.level = RAW_NOTIFY_SMB2;
+	notify.smb2.in.buffer_size = 1000;
+	notify.smb2.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+	notify.smb2.in.file.handle = h1;
+	notify.smb2.in.recursive = true;
+
+	torture_comment(torture, "testing notify mkdir\n");
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_cancel(req);
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_CANCELLED);
+
+	notify.smb2.in.recursive = true;
+	req = smb2_notify_send(tree, &(notify.smb2));
+	status = smb2_util_mkdir(tree, fname);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "testing notify rmdir\n");
+	req = smb2_notify_send(tree, &(notify.smb2));
+	status = smb2_util_rmdir(tree, fname);
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "SIMPLE CHANGE NOTIFY OK\n");
+
+	torture_comment(torture, "TESTING WITH SECONDARY TCON\n");
+	tree1 = secondary_tcon(tree, torture);
+
+	torture_comment(torture, "testing notify mkdir\n");
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_util_mkdir(tree1, fname);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "testing notify rmdir\n");
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_util_rmdir(tree, fname);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "CHANGE NOTIFY WITH TCON OK\n");
+
+	torture_comment(torture, "Disconnecting secondary tree\n");
+	status = smb2_tdis(tree1);
+	CHECK_STATUS(status, NT_STATUS_OK);
+	talloc_free(tree1);
+
+	torture_comment(torture, "testing notify mkdir\n");
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_util_mkdir(tree, fname);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_ADDED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "testing notify rmdir\n");
+	req = smb2_notify_send(tree, &(notify.smb2));
+	smb2_util_rmdir(tree, fname);
+
+	status = smb2_notify_recv(req, torture, &(notify.smb2));
+	CHECK_STATUS(status, NT_STATUS_OK);
+	CHECK_VAL(notify.smb2.out.num_changes, 1);
+	CHECK_VAL(notify.smb2.out.changes[0].action, NOTIFY_ACTION_REMOVED);
+	CHECK_WIRE_STR(notify.smb2.out.changes[0].name, "subdir-name");
+
+	torture_comment(torture, "CHANGE NOTIFY WITH TDIS OK\n");
+done:
+	smb2_util_close(tree, h1);
+	smb2_deltree(tree, BASEDIR);
+
+	return ret;
+}
+
+/*
+   basic testing of SMB2 change notify
+*/
+struct torture_suite *torture_smb2_notify_init(void)
+{
+	struct torture_suite *suite = torture_suite_create(talloc_autofree_context(), "NOTIFY");
+
+	torture_suite_add_1smb2_test(suite, "VALID-REQ", test_valid_request);
+	torture_suite_add_1smb2_test(suite, "TCON", torture_smb2_notify_tcon);
+	torture_suite_add_2smb2_test(suite, "DIR", torture_smb2_notify_dir);
+	torture_suite_add_2smb2_test(suite, "MASK", torture_smb2_notify_mask);
+	torture_suite_add_1smb2_test(suite, "TDIS", torture_smb2_notify_tree_disconnect);
+	torture_suite_add_2smb2_test(suite, "MASK-CHANGE", torture_smb2_notify_mask_change);
+	torture_suite_add_2smb2_test(suite, "LOGOFF", torture_smb2_notify_ulogoff);
+	torture_suite_add_1smb2_test(suite, "TREE", torture_smb2_notify_tree);
+	torture_suite_add_2smb2_test(suite, "BASEDIR", torture_smb2_notify_basedir);
+	torture_suite_add_2smb2_test(suite, "DOUBLE", torture_smb2_notify_double);
+	torture_suite_add_1smb2_test(suite, "FILE", torture_smb2_notify_file);
+	torture_suite_add_1smb2_test(suite, "TCP", torture_smb2_notify_tcp_disconnect);
+	torture_suite_add_2smb2_test(suite, "REC", torture_smb2_notify_recursive);
+	torture_suite_add_1smb2_test(suite, "OVERFLOW", torture_smb2_notify_overflow);
+
+	suite->description = talloc_strdup(suite, "SMB2-NOTIFY tests");
+
+	return suite;
+}
+
diff --git a/source4/torture/smb2/smb2.c b/source4/torture/smb2/smb2.c
index f61a6857b5..cff71f8053 100644
--- a/source4/torture/smb2/smb2.c
+++ b/source4/torture/smb2/smb2.c
@@ -136,7 +136,7 @@ NTSTATUS torture_smb2_init(void)
 	torture_suite_add_suite(suite, torture_smb2_lock_init());
 	torture_suite_add_suite(suite, torture_smb2_read_init());
 	torture_suite_add_suite(suite, torture_smb2_create_init());
-	torture_suite_add_simple_test(suite, "NOTIFY", torture_smb2_notify);
+	torture_suite_add_suite(suite, torture_smb2_notify_init());
 	torture_suite_add_suite(suite, torture_smb2_durable_open_init());
 	torture_suite_add_suite(suite, torture_smb2_dir_init());
 	torture_suite_add_suite(suite, torture_smb2_lease_init());