diff options
| author | Slava Semushin <php-coder@altlinux.ru> | 2009-05-23 20:51:53 +0700 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2009-05-25 16:18:48 +0200 |
| commit | 5d2cd816459a30107b4ea011c1874b051aa29b1c (patch) | |
| tree | b0ccd2bb9c020ab42663dfb96a8e1d46104a5bad /source4/torture/smbiconv.c | |
| parent | 95dbd7d6dce2583e785a17d5862a1a16838ec352 (diff) | |
| download | samba-5d2cd816459a30107b4ea011c1874b051aa29b1c.tar.gz samba-5d2cd816459a30107b4ea011c1874b051aa29b1c.tar.bz2 samba-5d2cd816459a30107b4ea011c1874b051aa29b1c.zip | |
source{3,4}/torture/smbiconv.c(main): fixed file descriptor leak.
File descriptor leaks only when we use file instead of stdout.
Found by cppcheck:
[./source3/torture/smbiconv.c:219]: (error) Resource leak: out
[./source4/torture/smbiconv.c:211]: (error) Resource leak: out
Diffstat (limited to 'source4/torture/smbiconv.c')
| -rw-r--r-- | source4/torture/smbiconv.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/source4/torture/smbiconv.c b/source4/torture/smbiconv.c index 4eece66bdf..173f37175b 100644 --- a/source4/torture/smbiconv.c +++ b/source4/torture/smbiconv.c @@ -208,6 +208,7 @@ int main(int argc, char *argv[]) cd = smb_iconv_open_ex(tctx, to, from, lp_parm_bool(tctx->lp_ctx, NULL, "iconv", "native", true)); if((int)cd == -1) { DEBUG(0,("unable to find from or to encoding, exiting...\n")); + if (out != stdout) fclose(out); return 1; } |