summaryrefslogtreecommitdiff
path: root/source4
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2012-03-13 15:41:16 +0100
committerStefan Metzmacher <metze@samba.org>2012-03-15 07:35:28 +0100
commitcd1d5a29d4cf810acbdc79f8824c85e608eae129 (patch)
tree855f3d6649d2a340a7693870d43ed908dfd63c9e /source4
parent6d631e52cf53bb1b66e8a1f4ed7f5091014aa359 (diff)
downloadsamba-cd1d5a29d4cf810acbdc79f8824c85e608eae129.tar.gz
samba-cd1d5a29d4cf810acbdc79f8824c85e608eae129.tar.bz2
samba-cd1d5a29d4cf810acbdc79f8824c85e608eae129.zip
s4:librpc/rpc: use tevent_req_defer_callback() in dcerpc_alter_context_*
metze
Diffstat (limited to 'source4')
-rw-r--r--source4/librpc/rpc/dcerpc.c29
1 files changed, 29 insertions, 0 deletions
diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c
index c70340df70..d76b9709e4 100644
--- a/source4/librpc/rpc/dcerpc.c
+++ b/source4/librpc/rpc/dcerpc.c
@@ -1940,6 +1940,7 @@ uint32_t dcerpc_auth_level(struct dcecli_connection *c)
}
struct dcerpc_alter_context_state {
+ struct tevent_context *ev;
struct dcerpc_pipe *p;
};
@@ -1967,6 +1968,7 @@ struct tevent_req *dcerpc_alter_context_send(TALLOC_CTX *mem_ctx,
return NULL;
}
+ state->ev = ev;
state->p = p;
p->syntax = *syntax;
@@ -2045,10 +2047,25 @@ static void dcerpc_alter_context_fail_handler(struct rpc_request *subreq)
struct tevent_req *req =
talloc_get_type_abort(subreq->async.private_data,
struct tevent_req);
+ struct dcerpc_alter_context_state *state =
+ tevent_req_data(req,
+ struct dcerpc_alter_context_state);
NTSTATUS status = subreq->status;
TALLOC_FREE(subreq);
+ /*
+ * We trigger the callback in the next event run
+ * because the code in this file might trigger
+ * multiple request callbacks from within a single
+ * while loop.
+ *
+ * In order to avoid segfaults from within
+ * dcerpc_connection_dead() we call
+ * tevent_req_defer_callback().
+ */
+ tevent_req_defer_callback(req, state->ev);
+
tevent_req_nterror(req, status);
}
@@ -2072,6 +2089,18 @@ static void dcerpc_alter_context_recv_handler(struct rpc_request *subreq,
talloc_steal(state, raw_packet->data);
TALLOC_FREE(subreq);
+ /*
+ * We trigger the callback in the next event run
+ * because the code in this file might trigger
+ * multiple request callbacks from within a single
+ * while loop.
+ *
+ * In order to avoid segfaults from within
+ * dcerpc_connection_dead() we call
+ * tevent_req_defer_callback().
+ */
+ tevent_req_defer_callback(req, state->ev);
+
if (pkt->ptype == DCERPC_PKT_ALTER_RESP &&
pkt->u.alter_resp.num_results == 1 &&
pkt->u.alter_resp.ctx_list[0].result != 0) {