summaryrefslogtreecommitdiff
path: root/swat
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2012-04-12 13:15:23 -0700
committerJeremy Allison <jra@samba.org>2012-04-12 15:06:58 -0700
commit80a4e38d6465d8ae47ca113027421af852d34316 (patch)
tree29cec65c62f31bd5216ef6d0feb5b1b3346ecbbd /swat
parentf6328b14c8d5fbc36d4597ebd52f74bfd60d92fc (diff)
downloadsamba-80a4e38d6465d8ae47ca113027421af852d34316.tar.gz
samba-80a4e38d6465d8ae47ca113027421af852d34316.tar.bz2
samba-80a4e38d6465d8ae47ca113027421af852d34316.zip
Fix the same bug reported by Kirill Malkin <kirill.malkin@starboardstorage.com> and
fixed by Volker for vfs_aio_fork as ref 0aacdbfada46329e0ad9dacfa90041a1c7dbf3e8. From that change: aio_suspend does not signal the main process with a signal, it just waits. The aio_fork module does not use the signal at all, it directly calls back into the main smbd by calling smbd_aio_complete_aio_ex. This is an abstraction violation, but the alternative would have been to use signals where they are not needed. However, in wait_for_aio_completion this bites us: With aio_fork we call handle_aio_completed twice on the same aio_ex struct: Once from the call to handle_aio_completion within the aio_fork module and once from the code in wait_for_aio_completion. Fix this differently here by not calling directly back into smbd, but using a new function aio_linux_setup_returns() to setup the return values that wait_for_aio_completion() in the main smbd will pick up by calling handle_aio_completd().
Diffstat (limited to 'swat')
0 files changed, 0 insertions, 0 deletions