Age | Commit message (Collapse) | Author | Files | Lines |
|
(This used to be commit c2a266b7b661d319e13982bfdbc3a86e8502b8a4)
|
|
Jeremy.
(This used to be commit 11077368ec30313c2e7ee1d23f9f348910aa36bf)
|
|
Jeremy.
(This used to be commit 13ab94fa73dbaf54da0169bbcf4d027d5c07d207)
|
|
(not tested yet)
(This used to be commit 0d6cec90c13731827abcbc61974efc993e794003)
|
|
(This used to be commit 8338e74ac4e5f31150c96f459a67e52090dc6013)
|
|
Jeremy.
(This used to be commit c0930e6d15eb68f06453d9b67142ccd7fb1370a0)
|
|
Jeremy.
(This used to be commit 723e9ee31cc1f5eb4b7aefefd58f7f13d0abda05)
|
|
(This used to be commit b20bcf8d336b4b2079eb42342a96d1fe714709de)
|
|
Jeremy.
(This used to be commit e81427c2d69be166afad94bc083e750e8f48fba7)
|
|
Jeremy.
(This used to be commit 183ce97d3719080b1b01932b96206b8ee4c5f5b0)
|
|
Jeremy.
(This used to be commit 7f8d3a49b2cebab4b94db3cda54b3923442378c8)
|
|
-------------------------------------------------------------------------
I think there are basically two problem:
1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
and SMB_ACL_OTHER.
The function ensure_canon_entry_valid() is prepared for that, but tries
to "guess" values from group or other permissions, respectively, otherwise
falling back to minimum r-- for the owner. Even if the owner had full
permissions before setting ACL. This is the problem with W2k clients.
2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
This is ok in a take-ownership situation, but must fail if the file is
to be given away. This is the problem with XP clients, trying to transfer
ownership of the original file to the temp file.
The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.
I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:
1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
as "preserve current value" instead of attempting to build one ourself.
The original code is still in, but only as fallback in case current values
can't be retrieved.
2. Rearrange set_nt_acl() such that chown is only done before setting
ACLs if there is either no change of owning user, or change of owning
user is towards the current user. Otherwise chown is done after setting
ACLs.
It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
(This used to be commit 1d3b8c528bebfa1971d1affe454a03453335786e)
|
|
-------------------------------------------------------------------------
I think there are basically two problem:
1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
and SMB_ACL_OTHER.
The function ensure_canon_entry_valid() is prepared for that, but tries
to "guess" values from group or other permissions, respectively, otherwise
falling back to minimum r-- for the owner. Even if the owner had full
permissions before setting ACL. This is the problem with W2k clients.
2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
This is ok in a take-ownership situation, but must fail if the file is
to be given away. This is the problem with XP clients, trying to transfer
ownership of the original file to the temp file.
The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.
I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:
1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
as "preserve current value" instead of attempting to build one ourself.
The original code is still in, but only as fallback in case current values
can't be retrieved.
2. Rearrange set_nt_acl() such that chown is only done before setting
ACLs if there is either no change of owning user, or change of owning
user is towards the current user. Otherwise chown is done after setting
ACLs.
It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
(This used to be commit 8ec20cbae7ca7e685b1a4186d8482c7405915dc3)
|
|
genparser works fine, and it is a marvelous tool to store objects in tdb :)
(This used to be commit 4c6d461a8572f03cd33cba95500cc837638b732c)
|
|
for name->sid.
(This used to be commit 0ebccc0dbeecc10d423529909a2563fbc3bf9857)
|
|
IP address resolving code.
(This used to be commit 1f605fe77c56ee2a7838c9f87eedf4bb91ebf688)
|
|
Jeremy.
(This used to be commit 05a8a61af83a6d85ddbb70749c8cd0abe9eb8180)
|
|
Jeremy.
(This used to be commit 1cbd53dc3cd2d56f5e62d42fed5d589efcecb8f8)
|
|
differently to W2K, cope with this.
Jeremy.
(This used to be commit 5e2755508f08ecf561348d4edf0a4064732c5213)
|
|
differently to W2K, cope with this.
Jeremy.
(This used to be commit 172f415c9eaa4d310a52794e3dc1a6bc92206ce4)
|
|
(This used to be commit d41dbe568ec77e4860678e5ee4fe2ab2f2da507b)
|
|
(This used to be commit 401a522d88abdb6d6f01707f51b658d4e0497d3d)
|
|
(This used to be commit 52ef84b53495db1eac6ecfb0b926ef8df7ea5cc5)
|
|
(This used to be commit 21ec2b6ba3ddba6964f6ddb53f8494e4a8b48a83)
|
|
Samba. This fixes things like not doing *SMBSERVER etc.
Andrew Bartlett
(This used to be commit 8863ff863c1da42aa6b8718f315c608d9d9067c6)
|
|
(This used to be commit d8d2d5e75503ae2b6532a25e4c9bbcdf20cc60af)
|
|
Andrew Bartlett
(This used to be commit 42b5514404bc7e33306c11344c6c934a1f83d295)
|
|
(This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec)
|
|
(This used to be commit 460339db2246b0213252ee34f507eb8e55ecbecb)
|
|
a test ...
(This used to be commit 1128a2fb4c16681e669efe605ff7d7161a2f7acd)
|
|
(This used to be commit 214decbda680f23691f0d633d4a29c2c7e17de6b)
|
|
(This used to be commit b467e9ce1d68e269c6956520a5ffce73e115714e)
|
|
function usage.
Andrew Bartlett
(This used to be commit cdc6139a9646b267a9921fc11fa532640a2e4c7f)
|
|
all perfectly legit - the region is an fstring in length, but might not
always be, and it is the last peice of code to fail my automated test.
Andrew Bartlett
(This used to be commit 762d61b37d053568b6346e249ba7ef594320153a)
|
|
failures for some compile-time properties this way.
Andrew Bartlett
(This used to be commit ce618624b7df797e228f8ef0f19820b318c62ae9)
|
|
(This used to be commit 243c9c37a53501b96df6286517e03eb09efcc620)
|
|
behaviour we should seperate -g from --enable-developer, and allow developers
to also select --enable-debug if they want.
Andrew Bartlett
(This used to be commit 96d1449c42597ea22c538a004960b26925c641fc)
|
|
(This used to be commit b32ae2d83fd0b4dd2c313cd0727bd276564cec0c)
|
|
command. From Ronan Waide <waider@waider.ie>.
(This used to be commit 992b5eb4e05fbf99d91d7235b9a002957533f95b)
|
|
Jeremy.
(This used to be commit 7b945e10a6c636c0b0aabc841803bf44405cb2ae)
|
|
Jeremy.
(This used to be commit fa93763248f2043395e4cfc70b8afd81e28b2b75)
|
|
Jeremy.
(This used to be commit 60b0cfc8a5b6275d3460ebc6bf17d0f08e25b67e)
|
|
Jeremy.
(This used to be commit c832e95c2f4daf175954a60f3c56420cf2f35b45)
|
|
Jeremy.
(This used to be commit 75b36459ab1797bdff98ed91d7870bd48adebb54)
|
|
\\server\share syntax, not just a "share" tconX syntax. This broke interop
with a vendor.
Jeremy.
(This used to be commit 3cc2ace7718ac1162494b81fa21d4cc9de021d1c)
|
|
\\server\share syntax, not just a "share" tconX syntax. This broke interop
with a vendor.
Jeremy.
(This used to be commit 9d7ea5585c873156ede4b56e43a0d4d75077283a)
|
|
(This used to be commit ebd134c0ce0d4db51822a4c29a0de768fcfa261f)
|
|
(This used to be commit 7558ee9d47beab11099d0a9d89b2e74dc58c9935)
|
|
(This used to be commit f5c9895f83277f01282587697c84d31dc77102f6)
|
|
(This used to be commit 89bc3f1f7c10ab7c7fb8d2437c7e3d07f3e6f4fa)
|