summaryrefslogtreecommitdiff
path: root/source3/lib/dbwrap
AgeCommit message (Collapse)AuthorFilesLines
2013-08-28dbwrap_ctdb: Treat empty records as non-existingVolker Lendecke1-0/+10
This is a patch implementing the workaround Christian mentioned in https://bugzilla.samba.org/show_bug.cgi?id=10008#c5 Bug: https://bugzilla.samba.org/show_bug.cgi?id=10008 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2013-05-16s3:lib/dbwrap add missing curly bracesChristian Ambach1-2/+4
violation of README.Coding Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-04-26dbwrap: Allow dbwrap_record_watch_recv to not lock the recordVolker Lendecke1-0/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-03-26dbwrap-ctdb: Avoid a talloc_stackframe()Volker Lendecke1-4/+2
We have only a single allocation in this routine, so I think we can live without a stackframe. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-03-26dbwrap-ctdb: Use ctdbd_parse in db_ctdb_parse_recordVolker Lendecke1-9/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-03-25dbwrap: Use tdb_null in db_ctdb_deleteVolker Lendecke1-4/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Mon Mar 25 19:42:30 CET 2013 on sn-devel-104
2013-02-04s3:dbrwap_ctdb: ZERO_STRUCT(rec) just to be sure in ↵Michael Adam1-0/+1
traverse_persistent_callback_read() Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-04s3:dbwrap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_read_callback()Michael Adam1-0/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-04s3:dbwrap_ctdb: add "db_context" to "db_record"Stefan Metzmacher1-2/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-04s3:dbwrap_ctdb: setup result->name in db_open_ctdb()Stefan Metzmacher1-0/+7
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-01-11dbwrap: Use INCOMPATIBLE_HASH for dbwrap_watchers.tdbVolker Lendecke1-3/+4
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2012-11-29dbwrap: Do not rely on dbwrap_record_get_value to return a talloc objectVolker Lendecke1-2/+3
db_tdb_fetch_locked returns the value as part of a larger talloc object that also contains the key. This means we can not realloc, but have to freshly alloc. Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 29 20:21:51 CET 2012 on sn-devel-104
2012-11-29s3: Remove db_ctdb_fetchVolker Lendecke1-55/+11
Note that this also makes the request for read only copies much more explicity visible in the code. Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Directly parse local existing records in db_ctdb_parse_recordVolker Lendecke1-0/+22
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copyVolker Lendecke1-11/+14
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Remove unused code for fetching persistent ctdb recordsVolker Lendecke1-129/+0
The only entry point here is parse_record, and this catches the persistent case with a direct parse now Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Avoid db_ctdb_fetch for persistent databasesVolker Lendecke1-0/+44
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Factor out parse_newest_in_marshall_buffer from ↵Volker Lendecke1-15/+51
pull_newest_from_marshall_buffer Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parseVolker Lendecke1-48/+21
now that the db_ctdb_marshall_loop_next_key has been factored out. Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_nextVolker Lendecke1-9/+24
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Slightly simplify db_ctdb_marshall_loop_nextVolker Lendecke1-4/+3
Both callers give a key argument Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_dbVolker Lendecke1-20/+21
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetchVolker Lendecke1-30/+46
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Add db_ctdb_ltdb_parseVolker Lendecke1-0/+42
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Slightly simplify db_ctdb_transaction_commitVolker Lendecke1-1/+2
Avoid an unnecessary "else". Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-29s3: Remove header==NULL code from db_ctdb_marshall_recordVolker Lendecke1-12/+5
The only call chain (via db_ctdb_marshall_add) has header != NULL Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-20s3: Fix some blank line endingsVolker Lendecke1-10/+10
Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Nov 20 19:18:33 CET 2012 on sn-devel-104
2012-09-21s3:dbwrap_ctdb: set errno = ENOSYS if clustering is not supportedGregor Beck1-0/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Sep 21 18:05:56 CEST 2012 on sn-devel-104
2012-09-04s3: Fix a commentVolker Lendecke1-1/+1
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-08-31s3:dbwrap_ctdb: Add DB name and key to warning messageChristof Schmitt1-1/+8
When a operation takes too long, it is useful for debugging to know the DB and the key. Signed-off-by: Christian Ambach <ambi@samba.org>
2012-07-31s3:dbwrap_ctdb: initialize db_record->dbStefan Metzmacher1-0/+1
metze
2012-06-29s3_dbrwap_ctdb: improve a comment in db_ctdb_can_use_local_record()Michael Adam1-1/+3
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-29s3:dbwrap_ctdb: fix a comment in db_ctdb_fetch()Michael Adam1-2/+3
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-29s3:dbwrap_ctdb: expand the comment for the db_ctdb_can_use_local_copy() functionMichael Adam1-1/+4
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-29s3:dbwrap_ctdb: rename db_ctdb_own_record() -> db_ctdb_can_use_local_copy()Michael Adam1-3/+3
This matches the function's intention much closer, since it also tests whether we have a valid local read only copy. Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-29s3:dbrwap_ctdb: remove commented out legacy codeMichael Adam1-5/+1
2012-06-29s3:dbwrap_ctdb: fix fetch/fetch_locked when samba is built against old ctdbMichael Adam1-4/+3
The introduction of read only copies has broken the algorithm for deteting whether we can use the local record copy for fetch_locked and fetch: For fetch locked the new code always uses the local copy if there is one... This patch re-establish the original algorithm for the build against a ctdb without read only record copies. Reported-by: Gregor Beck <gbeck@sernet.de>
2012-06-27s3-param: Rename loadparm_s3_context -> loadparm_s3_helpersAndrew Bartlett2-2/+2
This helps clarify the role of this structure and wrapper function. The purpose here is to provide helper functions to the lib/param loadparm_context that point back at the s3 lp_ functions. This allows a struct loadparm_context to be passed to any point in the code, and always refer to the correct loadparm system. If this has not been set, the variables loaded in the lib/param code will be returned. As requested by Michael Adam. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jun 27 17:11:16 CEST 2012 on sn-devel-104
2012-06-27s3:lib:dbwrap: fix return value of db_ctdb_traverse[_read] for ↵Gregor Beck1-6/+17
non-persistent dbs to return the number of traversed records upon successful traverse. Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-22dbwrap: dbwrap_local_open()Rusty Russell1-3/+3
This simply opens a tdb: it will eventually switch depending on the extension. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-06-22dbwrap: remove get_flags().Rusty Russell1-8/+0
The flags returned were TDB-specific: this was only used for detecting the endianness of obsolete databases (the conversion code was put in in 2003, with reference to Samba 2.3). It's easier to remove it than to translate the NTDB flags to TDB flags, and it's a really weird thing to ask for anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-06-21s3:util: rename procid_equal() to serverid_equal()Michael Adam1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-14move the dbwrap library to the top levelMichael Adam14-2812/+2
Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Mon May 14 04:04:55 CEST 2012 on sn-devel-104
2012-05-13s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_tdb.cMichael Adam1-1/+1
2012-05-13s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_rbt.cMichael Adam1-2/+2
2012-05-13s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_ctdb.cMichael Adam1-6/+8
2012-05-13s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_file.cMichael Adam1-6/+7
2012-05-13s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_util.cMichael Adam1-9/+9
2012-05-13s3:dbwrap: move definition of dbwrap_lock_order to dbwrap.hMichael Adam4-8/+7
This is needed in all of the library, not only in the dbwrap_open part.
2012-04-24s3: Fix Coverity ID 2751: REVERSE_INULLVolker Lendecke1-1/+1