summaryrefslogtreecommitdiff
path: root/source3/printing/nt_printing_ads.c
AgeCommit message (Collapse)AuthorFilesLines
2013-07-19s3-printing: avoid KRB5CCNAME overwrite in printer publishing (Bug #7444).Günther Deschner1-0/+13
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Jul 19 17:53:08 CEST 2013 on sn-devel-104
2013-06-03Fix bug 9900: is_printer_published GUID retrievalDavid Disseldorp1-47/+82
Samba currently always responds to GetPrinter(level = 7) requests with DSPRINT_UNPUBLISH, regardless of the AD publish status tracked via the PRINTER_ATTRIBUTE_PUBLISHED flag. This is due to erroneous "objectGUID" unmarshalling in is_printer_published(). This change splits "objectGUID" retrieval into a separate function, and adds a pull_reg_sz() call to correctly unmarshall the GUID. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-06-03printing: explicitly clear PUBLISHED attributeDavid Disseldorp1-1/+1
Currently nt_printer_publish(DSPRINT_UNPUBLISH) flips (via xor) the info2->attributes PRINTER_ATTRIBUTE_PUBLISHED flag, rather than explicitly clearing it. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2013-04-25bug 9830: fix panic in nt_printer_publish_adsDavid Disseldorp1-2/+8
Check for ads_find_machine_acct() errors, to ensure a NULL LDAPMessage pointer doesn't get passed to ldap_get_dn(). Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-By: Günther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Thu Apr 25 19:01:55 CEST 2013 on sn-devel-104
2013-01-18BUG 9378: Add extra attributes for AD printer publishing.David Disseldorp1-1/+85
Currently attempting to publish a printer in AD fails with "Object class violation", due to a number of missing attributes in the LDAP request. Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Jan 18 17:27:35 CET 2013 on sn-devel-104
2013-01-18printing: Remove invalid free from error path.David Disseldorp1-1/+0
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-07-18loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.Rusty Russell1-1/+1
They use talloc_tos() internally: hoist that up to the callers, some of whom don't want to us talloc_tos(). A simple patch, but hits a lot of files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-03-14s3-printing: Make printer a const char *.Andreas Schneider1-2/+6
2011-07-20s3-auth Use the common auth_session_infoAndrew Bartlett1-6/+6
This patch finally has the same structure being used to describe the authorization data of a user across the whole codebase. This will allow of our session handling to be accomplished with common code. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-20s3-auth Use struct auth3_session_info outside the auth subsystemAndrew Bartlett1-6/+6
This seperation between the structure used inside the auth modules and in the wider codebase allows for a gradual migration from struct auth_serversupplied_info -> struct auth_session_info (from auth.idl) The idea here is that we keep a clear seperation between the structure before and after the local groups, local user lookup and the session key modifications have been processed, as the lack of this seperation has caused issues in the past. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-07s3-printing: safe a ton of roundtrips by reusing existing winreg ↵Günther Deschner1-2/+11
binding_handles. Guenther Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07s3-printing: use winreg_internal functions.Günther Deschner1-5/+5
Guenther Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07s3-printing: add winreg_internal functions.Günther Deschner1-0/+1
Guenther Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-06-09s3-param Remove special case for global_myname(), rename to lp_netbios_name()Andrew Bartlett1-2/+2
There is no reason this can't be a normal constant string in the loadparm system, now that we have lp_set_cmdline() to handle overrides correctly. Andrew Bartlett
2011-05-02s3-printing: include ../librpc/ndr/libndr.h in ads printing.Günther Deschner1-0/+1
Guenther
2011-03-30s3-auth: printing needs auth.hGünther Deschner1-0/+1
Guenther
2011-03-30registry: create and use shared libcli/registry/util_reg.h header.Günther Deschner1-0/+1
Guenther
2011-02-22s3-auth Rename auth_serversupplied_info varaiables: server_info -> session_infoAndrew Bartlett1-16/+16
These variables, of type struct auth_serversupplied_info were poorly named when added into 2001, and in good consistant practice, this has extended all over the codebase in the years since. The structure is also not ideal for it's current purpose. Originally intended to convey the results of the authentication modules, it really describes all the essential attributes of a session. This rename will reduce the volume of a future patch to replaced these with a struct auth_session_info, with auth_serversupplied_info confined to the lower levels of the auth subsystem, and then eliminated. (The new structure will be the output of create_local_token(), and the change in struct definition will ensure that this is always run, populating local groups and privileges). Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-02-10s3-rpc_server: move services into individual directories.Günther Deschner1-1/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Feb 10 22:13:17 CET 2011 on sn-devel-104
2010-10-03s3: Attempt to fix the non-ads buildVolker Lendecke1-1/+1
2010-09-30s3-spoolss: Fix servername/printername handling which turns out to be very ↵Günther Deschner1-3/+3
important to get right. Guenther
2010-09-20s3-libads call common GUID_from_ndr_blob()Andrew Bartlett1-2/+5
This does a length-limited check, and so avoids reading beyond the allocated memory if the server sends less than 16 bytes. Andrew Bartlett Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-10s3-printing: fix non-ads build after prototype changes.Günther Deschner1-1/+1
Guenther
2010-09-09s3-printing: Make missing auth_serversupplied_info const.Andreas Schneider1-3/+3
2010-08-26s3-build: only include krb5 environment variables where required.Günther Deschner1-0/+1
Guenther
2010-08-08s3: Fix the build without ADSVolker Lendecke1-1/+3
2010-08-08s3: Lift the smbd_messaging_context from is_printer_publishedVolker Lendecke1-4/+4
2010-08-08s3: Lift the smbd_messaging_context from check_published_printersVolker Lendecke1-6/+5
2010-08-08s3: Lift the smbd_messaging_context from nt_printer_publishVolker Lendecke1-4/+3
2010-08-08s3: Lift the smbd_messaging_context from nt_printer_publish_adsVolker Lendecke1-4/+7
2010-08-08s3: Lift the smbd_messaging_context from store_printer_guidVolker Lendecke1-4/+4
2010-08-08s3: Lift the smbd_messaging_context from winreg_get_printer_dataexVolker Lendecke1-1/+2
2010-08-08s3: Lift the smbd_messaging_context from winreg_set_printer_dataexVolker Lendecke1-1/+3
2010-08-08s3: Lift the smbd_messaging_context from winreg_get_printerVolker Lendecke1-1/+3
2010-08-08s3: Lift the smbd_messaging_context from winreg_update_printerVolker Lendecke1-0/+1
2010-08-05s3-secrets: only include secrets.h when needed.Günther Deschner1-0/+1
Guenther
2010-08-05s3-printing: move AD related printing components to an own file.Günther Deschner1-0/+466
Guenther