summaryrefslogtreecommitdiff
path: root/source3/winbindd/winbindd_group.c
AgeCommit message (Collapse)AuthorFilesLines
2009-06-14Make winbindd_cli_state->response a pointer instead of a struct memberVolker Lendecke1-33/+33
Same comment as in baa6084378e530b: This is just a preparatory checkin. Volker
2009-06-14Make winbindd_cli_state->request a pointer instead of a struct memberVolker Lendecke1-30/+30
In itself, this is pretty pointless. But in the next steps I'll convert the winbind internal communication to wb_reqtrans which allocates the request properly. This minimizes the later diff. Volker
2009-06-08Pass a talloc_ctx to pdb_enum_aliasmemVolker Lendecke1-2/+2
2009-06-08s3-winbindd: workaround alias enumeration in expand_groups().Günther Deschner1-3/+16
alias enumeration in NSS is not done properly done atm and needs to be fixed. Guenther
2009-06-06s3-winbindd: add some debug statements while tracking down a bug.Günther Deschner1-2/+14
Guenther
2009-05-12Convert response.extra_data.data from malloc to tallocVolker Lendecke1-22/+14
2009-03-12Make opt_nocache static to winbindd.cVolker Lendecke1-2/+0
2009-02-11s3: Implement wbcGetSidAliasesDan Sledz1-0/+115
* Adds wbcGetSidAliases that calls the lookup_useraliases function. * Updates wbinfo and winbind_util.c to call the new function. * Also added winbind_get_groups helper function.
2009-02-02s3 build: Fix "assignment discards qualifiers from pointer target type" warningsTim Prouty1-6/+2
2009-02-02s3:winbind_group: fix "getent group" to allocate new gids.Michael Adam1-2/+8
"getent group" used to fill the idmap cache with negative cache entries for unmapped group sids. Don't pass domain name unconditionally to idmap_sid_to_gid(). idmap_sid_to_gid() only creates new mappings (allocating idmap backends tdb, tdb2, ldap...) when the domain name passed in is "". Note that it is _wrong_ to directly call the idmap_sid_to_gid() functions here, in the main winbindd. The correct fix would be to send a sid_to_gid request to winbindd itself, but this needs more work to prepare the async mechanisms, and we nee a quick fix for getent passwd now. Michael
2009-01-21Memory leaks and other fixes found by Coveritytodd stecher1-1/+7
2008-12-04s3:winbindd: fix horrible mis-indentation of toplvl braces in ↵Michael Adam1-2/+2
getgrsid_sid2gid_recv to make code more readble Michael
2008-12-04s3:winbindd: don't open a new dc connection in winbindd_getgrnam (main winbindd)Michael Adam1-1/+1
This is just to find the corresponding domain struct. Actual connection is handled by the domain child. Michael
2008-11-18Whitespace and >80 column cleanups.Steven Danneman1-2/+2
2008-11-02[s3]winbindd: speed up fill_grent_mem (i.e. winbindd_getgrent) a lot.Michael Adam1-13/+20
With large groups, getgrent ran into timeouts because after each single user that was added to the expanded group list, the list was sorted and made unique. Now the list is sorted just once after all members have been added. Michael
2008-09-23[s3]winbindd_group: don't list the domain twice when expanding internal aliasesMichael Adam1-1/+1
Before this, "getent group builtin\\administrators" expanded domain group members in the form DOMAIN\domain\user. Michael
2008-09-23[s3]winbindd_group: sanely handle NULL domain in add_member().Michael Adam1-1/+5
Michael
2008-09-16winbindd: Update the calls to ws_name_XX() to reflect API changes.Gerald (Jerry) Carter1-30/+152
* Ensures that all points an which a name is received or returned to/from a client passes through the name aliases layer (users and groups).
2008-09-11Fix for bug 5571Simo Sorce1-1/+1
Make sure that usernames are parsed using the correct separator. Otherwise group memeberships in winbind may be result broken. (This used to be commit 20b9c0aa7b4e6d6be5bb6e4e96bd8a1cbb6edd37)
2008-08-12idmap rewriteVolker Lendecke1-2/+4
(This used to be commit 30a180f2fce8cf6a3e5548f6bba453272ba70b33)
2008-07-06Clean up winbindd_group.c tooSimo Sorce1-210/+255
(This used to be commit 50a347f5503ebed0fcc7b9de60f8368677585bb1)
2008-06-30Fix from Atte Peltomäki - atte.peltomaki@f-secure.com to correctly checkJeremy Allison1-1/+1
error code in winbindd group expansion. Jeremy. (This used to be commit e321377174f579ba57a70f260f4d4bc234a07439)
2008-06-26From Steve Danneman @ Isilon.Jeremy Allison1-103/+1
Attached is the companion patch to (037b9689d9042a398cb91e4628a82fcdfa913c21), which made handling of WINBINDD_LIST_GROUPS asynchronous. Because most all of the list_groups code was reusable, I abstracted it, and implemented both list_groups and list_users on top of it. On my large test domain a "wbinfo -u" call went from 70 seconds to 30 seconds with this patch. Plus, the parent process is no longer blocked from receiving new requests during that time. Steven Danneman | Software Development Engineer Isilon Systems P +1-206-315-7500 F +1-206-315-7501 www.isilon.com (This used to be commit 5188f2861137ff06d5399561d55d7d00c3a08644)
2008-05-25Fix two c++ warningsVolker Lendecke1-1/+2
(This used to be commit 3b1dae7c31b881834ca4494c4434ae97a56ce6c7)
2008-05-22Make WINBINDD_LIST_GROUPS handler asynchronous.Steven Danneman1-58/+78
Previously WINBINDD_LIST_GROUPS requests (ex: wbinfo -g) were handled by the winbindd parent process in a sequential fashion. This patch, delegates the work to the winbindd children so that the request is handled much faster in large domain topologies, and doesn't block the parent from receiving new requests. The core group enumeration and conversion that was handled in winbindd_list_groups() has been moved into winbindd_dual_list_groups() to be done by the child. The parent winbindd_list_groups() simply calls each of the children asynchronously. listgroups_recv() aggregates the final group list that will be returned to the client and tracks how many of the children have returned their lists. The domain name of the child is passed back through the callbacks to be used in debugging messages. There are also several fixes to typos in various comments. (This used to be commit 037b9689d9042a398cb91e4628a82fcdfa913c21)
2008-04-22Fix wbinfo --group-info if the winbind separator set to non \Volker Lendecke1-2/+4
In getgrsid_lookupsid_recv() we use parse_domain_user which itself looks at lp_winbind_separator(). Thus when building up that group name we should better use it as well. (This used to be commit 5df75578ef1da41164936cd11b14114889201d47)
2008-04-07winbindd: fix break out early condition in fill_grent_mem().Michael Adam1-1/+1
if (!&new_glist) would always be skipped, if (new_glist == NULL) is what must have been meant... Michael (This used to be commit c1b60cdecff2a53f0a75a432a1ad7730eb734908)
2008-03-29Don't let winbind getgroups crash when we have no gids in the token.Günther Deschner1-3/+5
Guenther (This used to be commit 6a576cfe9b87e69af6acbe9abc04124b8b743fd3)
2008-01-09Convert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.Michael Adam1-9/+6
Michael (This used to be commit 6b2b9a60ef857ec31da5fea631535205fbdede4a)
2008-01-04Ensure that winbindd_getgroups() can deal with a UPN name.Gerald (Jerry) Carter1-1/+10
A user logging in via GDM was not getting a complete list of supplementary groups in his/her token. This is because getgroup() was not able to find the winbindd_domain* using the DNS name. Fallback to matching the DNS name is the short name match failes. (This used to be commit 2030a8de19a2c7c735a8aa367dd953e4a5c447b8)
2007-12-21Add NT error to debug to try and track this down.Jeremy Allison1-1/+4
Jermey. (This used to be commit a1482b09150f4d292965c77bc73d47fb14f5eb85)
2007-12-15s/sid_to_string/sid_to_fstring/Volker Lendecke1-2/+2
least surprise for callers (This used to be commit eb523ba77697346a365589101aac379febecd546)
2007-12-15Replace sid_string_static with sid_to_stringVolker Lendecke1-2/+4
This adds 28 fstrings on the stack, but I think an fstring on the stack is still far better than a static one. (This used to be commit c7c885078be8fd3024c186044ac28275d7609679)
2007-12-15Replace sid_string_static by sid_string_dbg in DEBUGsVolker Lendecke1-15/+16
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-23/+23
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10r25154: move winbindd code into winbindd/Stefan Metzmacher1-0/+1746
metze (This used to be commit 3ac7566ae14c48ff9b0f6b232e0ec4b2f73df558)