summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2010-12-14 10:42:26 +0100
committerStephen Gallagher <sgallagh@redhat.com>2010-12-14 17:13:29 -0500
commit6ad2d3a368074266cbf1420cc96922cc86876139 (patch)
tree0148fcb55873c466eddbfe2cd1c75d1fa64abb1e
parenta52139666b8217909c17ebb1b8eec1785194b894 (diff)
downloadsssd-6ad2d3a368074266cbf1420cc96922cc86876139.tar.gz
sssd-6ad2d3a368074266cbf1420cc96922cc86876139.tar.bz2
sssd-6ad2d3a368074266cbf1420cc96922cc86876139.zip
Fix improper NULL check in fo_add_srv_server()
https://fedorahosted.org/sssd/ticket/717
-rw-r--r--src/providers/fail_over.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/providers/fail_over.c b/src/providers/fail_over.c
index 858d6ba6..0c51b052 100644
--- a/src/providers/fail_over.c
+++ b/src/providers/fail_over.c
@@ -511,7 +511,8 @@ fo_add_srv_server(struct fo_service *service, const char *srv,
if (fo_is_srv_lookup(server)) {
if (((dns_domain == NULL && server->srv_data->dns_domain == NULL) ||
- strcasecmp(server->srv_data->dns_domain, dns_domain) == 0) &&
+ (dns_domain != NULL && server->srv_data->dns_domain != NULL &&
+ strcasecmp(server->srv_data->dns_domain, dns_domain) == 0)) &&
strcasecmp(server->srv_data->proto, proto) == 0) {
return EEXIST;
}