summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephen Gallagher <sgallagh@redhat.com>2010-06-09 09:54:11 -0400
committerStephen Gallagher <sgallagh@redhat.com>2010-06-10 10:17:38 -0400
commit6d8973d78dcf83c943f3cbc0cdb509987994a01b (patch)
treebf1e64a5f3c9934f6053736949d09e4a61943aef
parentf37bf8657971d16a4849f58242319699dca2de95 (diff)
downloadsssd-6d8973d78dcf83c943f3cbc0cdb509987994a01b.tar.gz
sssd-6d8973d78dcf83c943f3cbc0cdb509987994a01b.tar.bz2
sssd-6d8973d78dcf83c943f3cbc0cdb509987994a01b.zip
Properly handle missing originalMemberOf entry in initgroups
Failing to return after the tevent_req_post() here can result in a null-pointer dereference (along with other hard-to-track bugs) https://fedorahosted.org/sssd/ticket/507
-rw-r--r--src/providers/ldap/sdap_async_accounts.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/providers/ldap/sdap_async_accounts.c b/src/providers/ldap/sdap_async_accounts.c
index f949e46a..46c622d4 100644
--- a/src/providers/ldap/sdap_async_accounts.c
+++ b/src/providers/ldap/sdap_async_accounts.c
@@ -1181,6 +1181,7 @@ static struct tevent_req *sdap_initgr_nested_send(TALLOC_CTX *memctx,
/* user with no groups ? */
tevent_req_error(req, ENOENT);
tevent_req_post(req, ev);
+ return req;
}
state->count = el->num_values;