diff options
| author | Pavel Březina <pbrezina@redhat.com> | 2012-11-13 15:42:48 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2012-11-14 17:11:15 +0100 |
| commit | 7379170a0860790f2739e07fffe3d6ec85264566 (patch) | |
| tree | cf14c7a9939ad4ad856d604b6855ebf0d3c545bd /src/responder/sudo | |
| parent | d38ffc9c92daeb62de7d28c409bdaeff98f82775 (diff) | |
| download | sssd-7379170a0860790f2739e07fffe3d6ec85264566.tar.gz sssd-7379170a0860790f2739e07fffe3d6ec85264566.tar.bz2 sssd-7379170a0860790f2739e07fffe3d6ec85264566.zip | |
sudo: do not send domain name with username
This caused troubles with subdomain users and it is not really
necessary. This patch does not change the protocol itself, that
should be done on the earliest possible occasion.
Part of https://fedorahosted.org/sssd/ticket/1616
Diffstat (limited to 'src/responder/sudo')
| -rw-r--r-- | src/responder/sudo/sudosrv_cmd.c | 4 | ||||
| -rw-r--r-- | src/responder/sudo/sudosrv_private.h | 1 | ||||
| -rw-r--r-- | src/responder/sudo/sudosrv_query.c | 6 |
3 files changed, 5 insertions, 6 deletions
diff --git a/src/responder/sudo/sudosrv_cmd.c b/src/responder/sudo/sudosrv_cmd.c index 440c8c5d..eb421373 100644 --- a/src/responder/sudo/sudosrv_cmd.c +++ b/src/responder/sudo/sudosrv_cmd.c @@ -85,7 +85,7 @@ static errno_t sudosrv_cmd_send_error(TALLOC_CTX *mem_ctx, return EFAULT; } - ret = sudosrv_build_response(mem_ctx, error, NULL, 0, NULL, + ret = sudosrv_build_response(mem_ctx, error, 0, NULL, &response_body, &response_len); if (ret != EOK) { return ret; @@ -118,7 +118,7 @@ errno_t sudosrv_cmd_done(struct sudo_cmd_ctx *cmd_ctx, int ret) /* send result */ ret = sudosrv_build_response(cmd_ctx, SSS_SUDO_ERROR_OK, - cmd_ctx->domain->name, num_rules, rules, + num_rules, rules, &response_body, &response_len); if (ret != EOK) { return EFAULT; diff --git a/src/responder/sudo/sudosrv_private.h b/src/responder/sudo/sudosrv_private.h index b8059407..c9eae57b 100644 --- a/src/responder/sudo/sudosrv_private.h +++ b/src/responder/sudo/sudosrv_private.h @@ -103,7 +103,6 @@ errno_t sudosrv_parse_query_recv(TALLOC_CTX *mem_ctx, errno_t sudosrv_build_response(TALLOC_CTX *mem_ctx, uint32_t error, - const char *domain, int rules_num, struct sysdb_attrs **rules, uint8_t **_response_body, diff --git a/src/responder/sudo/sudosrv_query.c b/src/responder/sudo/sudosrv_query.c index d76ecbb9..998b6023 100644 --- a/src/responder/sudo/sudosrv_query.c +++ b/src/responder/sudo/sudosrv_query.c @@ -188,7 +188,6 @@ done: */ errno_t sudosrv_build_response(TALLOC_CTX *mem_ctx, uint32_t error, - const char *domain, int rules_num, struct sysdb_attrs **rules, uint8_t **_response_body, @@ -217,8 +216,9 @@ errno_t sudosrv_build_response(TALLOC_CTX *mem_ctx, goto done; } - /* domain name */ - ret = sudosrv_response_append_string(tmp_ctx, domain, strlen(domain) + 1, + /* domain name - deprecated + * TODO: when possible change the protocol */ + ret = sudosrv_response_append_string(tmp_ctx, "\0", 1, &response_body, &response_len); if (ret != EOK) { goto fail; |