summaryrefslogtreecommitdiff
path: root/src/sss_client/ssh
diff options
context:
space:
mode:
authorJan Cholasta <jcholast@redhat.com>2012-02-24 12:59:45 -0500
committerStephen Gallagher <sgallagh@redhat.com>2012-02-26 20:34:18 -0500
commite6ab4b3ded22aca8dd6eb3ce69630d931cddb140 (patch)
tree0989334454303b0ff42852f5d992d87a54ade348 /src/sss_client/ssh
parent1e68ae21e7ae46744700753ccf28bcbcaedbe017 (diff)
downloadsssd-e6ab4b3ded22aca8dd6eb3ce69630d931cddb140.tar.gz
sssd-e6ab4b3ded22aca8dd6eb3ce69630d931cddb140.tar.bz2
sssd-e6ab4b3ded22aca8dd6eb3ce69630d931cddb140.zip
SSH: Manage global known_hosts file in the responder
https://fedorahosted.org/sssd/ticket/1193
Diffstat (limited to 'src/sss_client/ssh')
-rw-r--r--src/sss_client/ssh/sss_ssh_knownhostsproxy.c80
1 files changed, 2 insertions, 78 deletions
diff --git a/src/sss_client/ssh/sss_ssh_knownhostsproxy.c b/src/sss_client/ssh/sss_ssh_knownhostsproxy.c
index c9c974b4..544ea719 100644
--- a/src/sss_client/ssh/sss_ssh_knownhostsproxy.c
+++ b/src/sss_client/ssh/sss_ssh_knownhostsproxy.c
@@ -21,7 +21,6 @@
#include <stdio.h>
#include <talloc.h>
#include <unistd.h>
-#include <pwd.h>
#include <fcntl.h>
#include <poll.h>
#include <sys/types.h>
@@ -214,15 +213,8 @@ int main(int argc, const char **argv)
POPT_TABLEEND
};
poptContext pc = NULL;
- const char *file;
- struct passwd *pwd;
const char *host;
- FILE *f;
- struct addrinfo ai_hint;
- struct addrinfo *ai = NULL;
struct sss_ssh_ent *ent;
- size_t i;
- char *repr;
int ret;
debug_prg_name = argv[0];
@@ -267,91 +259,24 @@ int main(int argc, const char **argv)
ret, fini);
}
- /* get absolute filename of the known_hosts file */
- if (pc_file && pc_file[0] != '/') {
- pwd = getpwuid(getuid());
- if (!pwd) {
- ret = errno;
- DEBUG(SSSDBG_OP_FAILURE, ("getpwuid() failed (%d): %s\n",
- ret, strerror(ret)));
- ERROR("Failed to get user's home directory\n");
- ret = EXIT_FAILURE;
- goto fini;
- }
-
- file = talloc_asprintf(mem_ctx, "%s/%s", pwd->pw_dir, pc_file);
- if (!file) {
- ERROR("Not enough memory\n");
- ret = EXIT_FAILURE;
- goto fini;
- }
- } else {
- file = pc_file;
- }
-
- /* get canonic hostname and IP addresses of the host */
- memset(&ai_hint, 0, sizeof(struct addrinfo));
- ai_hint.ai_family = AF_UNSPEC;
- ai_hint.ai_socktype = SOCK_STREAM;
- ai_hint.ai_protocol = IPPROTO_TCP;
- ai_hint.ai_flags = AI_CANONNAME | AI_ADDRCONFIG | AI_NUMERICSERV;
-
- ret = getaddrinfo(pc_host, pc_port, &ai_hint, &ai);
- if (ret) {
- DEBUG(SSSDBG_CRIT_FAILURE,
- ("getaddrinfo() failed (%d): %s\n", ret, gai_strerror(ret)));
- ERROR("Error looking up host\n");
- ret = EXIT_FAILURE;
- goto fini;
- }
-
/* append domain to hostname if domain is specified */
if (pc_domain) {
- host = talloc_asprintf(mem_ctx, "%s@%s", ai[0].ai_canonname, pc_domain);
+ host = talloc_asprintf(mem_ctx, "%s@%s", pc_host, pc_domain);
if (!host) {
ERROR("Not enough memory\n");
ret = EXIT_FAILURE;
goto fini;
}
} else {
- host = ai[0].ai_canonname;
+ host = pc_host;
}
/* look up public keys */
ret = sss_ssh_get_ent(mem_ctx, SSS_SSH_GET_HOST_PUBKEYS, host, &ent);
if (ret != EOK) {
ERROR("Error looking up public keys\n");
- ret = EXIT_FAILURE;
- goto fini;
- }
-
- /* write known_hosts file */
- /* FIXME: Do not overwrite the file, handle concurrent access */
- f = fopen(file, "w");
- if (!f) {
- ret = errno;
- DEBUG(SSSDBG_OP_FAILURE, ("fopen() failed (%d): %s\n",
- ret, strerror(ret)));
- ERROR("Can't open known hosts file\n");
- ret = EXIT_FAILURE;
- goto fini;
- }
-
- fprintf(f,
- "# Generated by sss_ssh_knownhostsproxy. Please do not modify.\n");
-
- for (i = 0; i < ent->num_pubkeys; i++) {
- repr = sss_ssh_format_pubkey(mem_ctx, ent, &ent->pubkeys[i],
- SSS_SSH_FORMAT_OPENSSH);
- if (!repr) {
- continue;
- }
-
- fprintf(f, "%s %s\n", pc_host, repr);
}
- fclose(f);
-
/* connect to server */
if (pc_args) {
ret = connect_proxy_command(discard_const(pc_args));
@@ -363,7 +288,6 @@ int main(int argc, const char **argv)
fini:
poptFreeContext(pc);
talloc_free(mem_ctx);
- if (ai) freeaddrinfo(ai);
return ret;
}