summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGerald Carter <jerry@samba.org>2006-07-22 00:53:19 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 11:38:18 -0500
commitefc7ac209da61d2bd389ccd3b8c8d6d6a6b53989 (patch)
tree30d2c4dad604608a690077e1963a9b54f8757e0e
parent7f5f781fe90c16f5d6b70962d45ed2a8e8c641d2 (diff)
downloadsamba-efc7ac209da61d2bd389ccd3b8c8d6d6a6b53989.tar.gz
samba-efc7ac209da61d2bd389ccd3b8c8d6d6a6b53989.tar.bz2
samba-efc7ac209da61d2bd389ccd3b8c8d6d6a6b53989.zip
r17183: LsaLookupSids() shoudl return the string form of a SID when
it cannot be mapped and not the hex of the RID. Who wrote that? (This used to be commit 4e51cf34cf4cbe77957d754952369df3a180f974)
-rw-r--r--source3/rpc_server/srv_lsa_nt.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/source3/rpc_server/srv_lsa_nt.c b/source3/rpc_server/srv_lsa_nt.c
index b4b8876db0..0d8ec75150 100644
--- a/source3/rpc_server/srv_lsa_nt.c
+++ b/source3/rpc_server/srv_lsa_nt.c
@@ -873,8 +873,9 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
if (name->type == SID_NAME_UNKNOWN) {
name->dom_idx = -1;
- name->name = talloc_asprintf(p->mem_ctx, "%8.8x",
- name->rid);
+ /* unknown sids should return the string representation of the SID */
+ name->name = talloc_asprintf(p->mem_ctx, "%s",
+ sid_string_static(sids[i]));
if (name->name == NULL) {
return NT_STATUS_NO_MEMORY;
}