diff options
| author | Jeremy Allison <jra@samba.org> | 2000-12-15 23:02:01 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2000-12-15 23:02:01 +0000 |
| commit | fb82ab78fe556656eec605d532e0dabb2f815573 (patch) | |
| tree | ba148fd8d255fccc7a1dbfa4c0ebdc7c1f835408 /source3/rpc_parse | |
| parent | 99c2693c620cd222da5561d526aa328bec426b77 (diff) | |
| download | samba-fb82ab78fe556656eec605d532e0dabb2f815573.tar.gz samba-fb82ab78fe556656eec605d532e0dabb2f815573.tar.bz2 samba-fb82ab78fe556656eec605d532e0dabb2f815573.zip | |
Never free anything in the rpc_parse/prs_XXX functions. Do it in the enclosing
function.
lib/util_unistr.c: Check lengths *before* reading source - prevent uninitialised
memory reads.
Jeremy.
(This used to be commit ce4f461965c872fbfc9fe5f6b98aed58bb3dd67a)
Diffstat (limited to 'source3/rpc_parse')
| -rw-r--r-- | source3/rpc_parse/parse_lsa.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/source3/rpc_parse/parse_lsa.c b/source3/rpc_parse/parse_lsa.c index 41219854d1..2c15166f26 100644 --- a/source3/rpc_parse/parse_lsa.c +++ b/source3/rpc_parse/parse_lsa.c @@ -853,16 +853,6 @@ static BOOL lsa_io_trans_names(char *desc, LSA_TRANS_NAME_ENUM *trn, if(!prs_align(ps)) return False; } - - /* Free memory if we've sent it */ - - if (MARSHALLING(ps)) { - safe_free(trn->name); - safe_free(trn->uni_name); - - trn->name = NULL; - trn->uni_name = NULL; - } } return True; |